Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove schemathesis and clean up api Makefile #15696

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Jan 9, 2025

Description

Remove schemathesis from the fullnode API and dev_setup.sh. It doesn't look like we're using this. Also cleaned up some targets for api v0 from the Makefile

How Has This Been Tested?

make test

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@aluon aluon requested a review from geekflyer January 9, 2025 17:13
Copy link

trunk-io bot commented Jan 9, 2025

@aluon aluon marked this pull request as ready for review January 9, 2025 17:20
@aluon aluon requested review from a team, banool, gregnazario and 0xmaayan as code owners January 9, 2025 17:20
@aluon aluon force-pushed the aluon/push-oyzlnnovttst branch from 0febbcc to f38d133 Compare January 13, 2025 19:53
@aluon aluon enabled auto-merge (squash) January 14, 2025 21:28

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on f38d13350d3675f0fb183276bc72b14fc4906ead

two traffics test: inner traffic : committed: 14846.51 txn/s, latency: 2678.52 ms, (p50: 2400 ms, p70: 2700, p90: 3000 ms, p99: 4500 ms), latency samples: 5644980
two traffics test : committed: 99.98 txn/s, latency: 1728.29 ms, (p50: 1300 ms, p70: 1400, p90: 3500 ms, p99: 4500 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.488, avg: 1.321", "ConsensusProposalToOrdered: max: 0.295, avg: 0.288", "ConsensusOrderedToCommit: max: 0.309, avg: 0.300", "ConsensusProposalToCommit: max: 0.601, avg: 0.588"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.51s no progress at version 297 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.57s no progress at version 2963092 (avg 0.57s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> f38d13350d3675f0fb183276bc72b14fc4906ead

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> f38d13350d3675f0fb183276bc72b14fc4906ead (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 16855.41 txn/s, latency: 2027.38 ms, (p50: 2100 ms, p70: 2200, p90: 2300 ms, p99: 2700 ms), latency samples: 556520
2. Upgrading first Validator to new version: f38d13350d3675f0fb183276bc72b14fc4906ead
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7592.06 txn/s, latency: 3929.93 ms, (p50: 4400 ms, p70: 4800, p90: 5100 ms, p99: 5100 ms), latency samples: 140360
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7622.95 txn/s, latency: 4452.10 ms, (p50: 4800 ms, p70: 4900, p90: 5200 ms, p99: 5300 ms), latency samples: 251600
3. Upgrading rest of first batch to new version: f38d13350d3675f0fb183276bc72b14fc4906ead
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6480.65 txn/s, latency: 4667.46 ms, (p50: 5500 ms, p70: 5600, p90: 5900 ms, p99: 6000 ms), latency samples: 120440
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6517.89 txn/s, latency: 5189.14 ms, (p50: 5600 ms, p70: 5700, p90: 5800 ms, p99: 6000 ms), latency samples: 223600
4. upgrading second batch to new version: f38d13350d3675f0fb183276bc72b14fc4906ead
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 5378.80 txn/s, latency: 5760.58 ms, (p50: 4500 ms, p70: 9700, p90: 10600 ms, p99: 11200 ms), latency samples: 94960
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9814.16 txn/s, latency: 3363.63 ms, (p50: 3400 ms, p70: 3800, p90: 4400 ms, p99: 5100 ms), latency samples: 325920
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> f38d13350d3675f0fb183276bc72b14fc4906ead passed
Test Ok

@aluon aluon merged commit 2712cc7 into main Jan 14, 2025
88 checks passed
@aluon aluon deleted the aluon/push-oyzlnnovttst branch January 14, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants