Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[framework] Replace coin store deletion event with coin type #15730

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

gregnazario
Copy link
Contributor

@gregnazario gregnazario commented Jan 14, 2025

Description

The original event didn't have the coin type which made it very hard for indexing. This replaces it.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

The original event didn't have the coin type which made
it very hard for indexing.  This replaces it.
Copy link

trunk-io bot commented Jan 14, 2025

⏱️ 53m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 24m 🟩
test-target-determinator 6m 🟩
rust-doc-tests 6m 🟩
execution-performance / test-target-determinator 5m 🟩
check-dynamic-deps 5m 🟩🟩
rust-cargo-deny 4m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 54s 🟩🟩
semgrep/ci 52s 🟩🟩
file_change_determinator 24s 🟩🟩
file_change_determinator 13s 🟩
permission-check 6s 🟩🟩
permission-check 3s 🟩🟩
permission-check 2s 🟩
determine-docker-build-metadata 2s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
test-target-determinator 6m 5m +30%

settingsfeedbackdocs ⋅ learn more about trunk.io

@gregnazario gregnazario requested review from lightmark and rtso January 14, 2025 19:29
@gregnazario gregnazario enabled auto-merge (squash) January 14, 2025 19:57

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> 4de088dab67ccde6c90a8543f6ca6988073ea965

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> 4de088dab67ccde6c90a8543f6ca6988073ea965 (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 17583.71 txn/s, latency: 1987.65 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2500 ms), latency samples: 573360
2. Upgrading first Validator to new version: 4de088dab67ccde6c90a8543f6ca6988073ea965
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4638.22 txn/s, latency: 6694.19 ms, (p50: 7400 ms, p70: 8000, p90: 8300 ms, p99: 8400 ms), latency samples: 94940
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4610.35 txn/s, latency: 7418.05 ms, (p50: 8300 ms, p70: 8400, p90: 8700 ms, p99: 8700 ms), latency samples: 164660
3. Upgrading rest of first batch to new version: 4de088dab67ccde6c90a8543f6ca6988073ea965
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4619.51 txn/s, latency: 6712.28 ms, (p50: 7400 ms, p70: 8000, p90: 8300 ms, p99: 8400 ms), latency samples: 94120
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4550.18 txn/s, latency: 7516.35 ms, (p50: 8300 ms, p70: 8300, p90: 8400 ms, p99: 8700 ms), latency samples: 164160
4. upgrading second batch to new version: 4de088dab67ccde6c90a8543f6ca6988073ea965
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9186.04 txn/s, latency: 3336.96 ms, (p50: 4000 ms, p70: 4100, p90: 4200 ms, p99: 4300 ms), latency samples: 164540
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8944.37 txn/s, latency: 3826.27 ms, (p50: 4200 ms, p70: 4200, p90: 4400 ms, p99: 4600 ms), latency samples: 292460
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> 4de088dab67ccde6c90a8543f6ca6988073ea965 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 4de088dab67ccde6c90a8543f6ca6988073ea965

two traffics test: inner traffic : committed: 14761.21 txn/s, latency: 2691.80 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3300 ms), latency samples: 5612540
two traffics test : committed: 100.00 txn/s, latency: 1377.17 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 2000 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.624, avg: 1.536", "ConsensusProposalToOrdered: max: 0.293, avg: 0.290", "ConsensusOrderedToCommit: max: 0.306, avg: 0.298", "ConsensusProposalToCommit: max: 0.597, avg: 0.587"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.53s no progress at version 990 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.56s no progress at version 2744398 (avg 0.56s) [limit 16].
Test Ok

@gregnazario gregnazario merged commit 74d6333 into aptos-labs:main Jan 14, 2025
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants