Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzing Tooling: cmin and precise stack trace for PartialVMErrors #15739

Merged
merged 4 commits into from
Jan 19, 2025

Conversation

zi0Black
Copy link
Contributor

Description

Enhance fuzz.sh script with cmin functionality for corpus minimization.

Introduce debug panic mechanism in errors.rs for improved stack trace during fuzzing, and update README.md for usage instructions.

How Has This Been Tested?

N/A

Key Areas to Review

If the changes in error.rs are okay, everything is features gated under fuzzing.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

…ion.

Introduce debug panic mechanism in errors.rs for improved error handling during fuzzing and update README.md for usage instructions.
Copy link

trunk-io bot commented Jan 15, 2025

⏱️ 1h 25m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 25m 🟩
forge-compat-test / forge 15m 🟩
check-dynamic-deps 11m 🟩🟩🟩🟩🟩
rust-cargo-deny 10m 🟩🟩🟩🟩🟩
test-target-determinator 6m 🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 5m 🟩
general-lints 3m 🟩🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
file_change_determinator 1m 🟩🟩🟩🟩🟩
file_change_determinator 18s 🟩
permission-check 15s 🟩🟩🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩🟩
permission-check 4s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
test-target-determinator 6m 5m +22%

settingsfeedbackdocs ⋅ learn more about trunk.io

remove useless collect
@zi0Black zi0Black enabled auto-merge (squash) January 18, 2025 22:14

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 5a8ccc9f6b4324871d70ec1d2fe9337e17379da0

two traffics test: inner traffic : committed: 15074.36 txn/s, latency: 2632.46 ms, (p50: 2700 ms, p70: 2700, p90: 2700 ms, p99: 3000 ms), latency samples: 5731560
two traffics test : committed: 99.99 txn/s, latency: 1350.15 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 2900 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.571, avg: 1.488", "ConsensusProposalToOrdered: max: 0.294, avg: 0.286", "ConsensusOrderedToCommit: max: 0.322, avg: 0.307", "ConsensusProposalToCommit: max: 0.612, avg: 0.593"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.80s no progress at version 24490 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.51s no progress at version 2776492 (avg 0.51s) [limit 16].
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 17540fad8e88ab5681f3a91190b9f5d37e53d2ef ==> 5a8ccc9f6b4324871d70ec1d2fe9337e17379da0

Compatibility test results for 17540fad8e88ab5681f3a91190b9f5d37e53d2ef ==> 5a8ccc9f6b4324871d70ec1d2fe9337e17379da0 (PR)
1. Check liveness of validators at old version: 17540fad8e88ab5681f3a91190b9f5d37e53d2ef
compatibility::simple-validator-upgrade::liveness-check : committed: 11408.08 txn/s, latency: 2783.46 ms, (p50: 2200 ms, p70: 2500, p90: 6400 ms, p99: 11200 ms), latency samples: 368820
2. Upgrading first Validator to new version: 5a8ccc9f6b4324871d70ec1d2fe9337e17379da0
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 1217.83 txn/s, submitted: 1217.98 txn/s, expired: 0.15 txn/s, latency: 7233.99 ms, (p50: 8000 ms, p70: 8600, p90: 9100 ms, p99: 9200 ms), latency samples: 91509
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4294.68 txn/s, latency: 7900.69 ms, (p50: 8800 ms, p70: 9000, p90: 9300 ms, p99: 9400 ms), latency samples: 151000
3. Upgrading rest of first batch to new version: 5a8ccc9f6b4324871d70ec1d2fe9337e17379da0
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3923.46 txn/s, latency: 7873.68 ms, (p50: 8600 ms, p70: 9400, p90: 9900 ms, p99: 10000 ms), latency samples: 87480
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3962.90 txn/s, latency: 8625.59 ms, (p50: 9600 ms, p70: 9700, p90: 10100 ms, p99: 10100 ms), latency samples: 140080
4. upgrading second batch to new version: 5a8ccc9f6b4324871d70ec1d2fe9337e17379da0
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 1955.71 txn/s, submitted: 1955.86 txn/s, expired: 0.15 txn/s, latency: 3878.50 ms, (p50: 4500 ms, p70: 4600, p90: 4900 ms, p99: 5100 ms), latency samples: 147229
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7856.77 txn/s, latency: 4365.58 ms, (p50: 4600 ms, p70: 4900, p90: 5100 ms, p99: 5300 ms), latency samples: 262600
5. check swarm health
Compatibility test for 17540fad8e88ab5681f3a91190b9f5d37e53d2ef ==> 5a8ccc9f6b4324871d70ec1d2fe9337e17379da0 passed
Test Ok

@zi0Black zi0Black merged commit b2b3d67 into main Jan 19, 2025
85 of 88 checks passed
@zi0Black zi0Black deleted the improve-fuzz-tooling branch January 19, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants