Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding back permission perf test #15765

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

igor-aptos
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@igor-aptos igor-aptos added the CICD:run-execution-performance-test Run execution performance test label Jan 17, 2025
Copy link

trunk-io bot commented Jan 17, 2025

⏱️ 3h 34m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 29m 🟥🟥🟥🟥🟩 (+3 more)
execution-performance / test-target-determinator 35m 🟩🟩🟩🟩🟩 (+3 more)
test-target-determinator 26m 🟩🟩🟩🟩 (+2 more)
check-dynamic-deps 24m 🟩🟩🟩🟩🟩 (+3 more)
rust-cargo-deny 11m 🟩🟩🟩🟩 (+2 more)
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 5m 🟩🟩🟩
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+3 more)
general-lints 3m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
permission-check 26s 🟩🟩🟩🟩🟩 (+3 more)
permission-check 20s 🟩🟩🟩🟩🟩 (+3 more)

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / test-target-determinator 4m 5m -24%
test-target-determinator 4m 5m -27%

settingsfeedbackdocs ⋅ learn more about trunk.io

@igor-aptos igor-aptos force-pushed the igor/add_back_permission_transfer_test branch from bf8f126 to 684590e Compare January 17, 2025 00:34
@igor-aptos igor-aptos force-pushed the igor/add_back_permission_transfer_test branch from 684590e to 1bbb138 Compare January 22, 2025 02:11
@igor-aptos igor-aptos force-pushed the igor/add_back_permission_transfer_test branch from 1bbb138 to 95d2bf9 Compare January 22, 2025 02:46
@igor-aptos igor-aptos enabled auto-merge (squash) January 22, 2025 02:47

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/add_back_permission_transfer_test branch from 95d2bf9 to 48b4403 Compare January 22, 2025 03:05
Comment on lines 27 to 28
APTTransferWithPermissionedSigner 34 0.946 1.091 1068.0
APTTransferWithMasterSigner 34 0.946 1.091 185.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tab-delimited format used throughout this file appears to be inconsistent in these two new lines. To maintain consistency, the spaces between fields should be replaced with tab characters. The lines should be formatted as:

APTTransferWithPermissionedSigner	34	0.946	1.091	1068.0
APTTransferWithMasterSigner	34	0.946	1.091	185.0

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/add_back_permission_transfer_test branch from 48b4403 to 2c8f58e Compare January 22, 2025 05:54

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on bb609ba7417025d8af1e199c345631c8b4b2c412 ==> 2c8f58ea0744045f59fec88b3f6b252f8cb4e5cd

Compatibility test results for bb609ba7417025d8af1e199c345631c8b4b2c412 ==> 2c8f58ea0744045f59fec88b3f6b252f8cb4e5cd (PR)
1. Check liveness of validators at old version: bb609ba7417025d8af1e199c345631c8b4b2c412
compatibility::simple-validator-upgrade::liveness-check : committed: 14314.89 txn/s, latency: 2187.77 ms, (p50: 2200 ms, p70: 2400, p90: 2800 ms, p99: 3800 ms), latency samples: 483580
2. Upgrading first Validator to new version: 2c8f58ea0744045f59fec88b3f6b252f8cb4e5cd
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3734.42 txn/s, latency: 8148.46 ms, (p50: 8800 ms, p70: 9600, p90: 10300 ms, p99: 10500 ms), latency samples: 82420
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3552.39 txn/s, latency: 9668.74 ms, (p50: 10300 ms, p70: 11200, p90: 11600 ms, p99: 11900 ms), latency samples: 132200
3. Upgrading rest of first batch to new version: 2c8f58ea0744045f59fec88b3f6b252f8cb4e5cd
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4317.90 txn/s, latency: 7196.03 ms, (p50: 8000 ms, p70: 8500, p90: 8900 ms, p99: 9100 ms), latency samples: 92040
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4324.10 txn/s, latency: 7857.44 ms, (p50: 8800 ms, p70: 9000, p90: 9100 ms, p99: 9300 ms), latency samples: 153040
4. upgrading second batch to new version: 2c8f58ea0744045f59fec88b3f6b252f8cb4e5cd
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 4222.04 txn/s, latency: 6954.00 ms, (p50: 6500 ms, p70: 9100, p90: 9700 ms, p99: 10000 ms), latency samples: 87220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5932.39 txn/s, latency: 5581.95 ms, (p50: 5000 ms, p70: 6700, p90: 8400 ms, p99: 8800 ms), latency samples: 209360
5. check swarm health
Compatibility test for bb609ba7417025d8af1e199c345631c8b4b2c412 ==> 2c8f58ea0744045f59fec88b3f6b252f8cb4e5cd passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 2c8f58ea0744045f59fec88b3f6b252f8cb4e5cd

two traffics test: inner traffic : committed: 14727.68 txn/s, latency: 2692.19 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5599880
two traffics test : committed: 99.97 txn/s, latency: 1455.16 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 1800 ms), latency samples: 1860
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.515, avg: 1.440", "ConsensusProposalToOrdered: max: 0.290, avg: 0.288", "ConsensusOrderedToCommit: max: 0.410, avg: 0.394", "ConsensusProposalToCommit: max: 0.698, avg: 0.682"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.51s no progress at version 605 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.63s no progress at version 1938816 (avg 0.58s) [limit 16].
Test Ok

@igor-aptos igor-aptos merged commit 95190dc into main Jan 22, 2025
46 checks passed
@igor-aptos igor-aptos deleted the igor/add_back_permission_transfer_test branch January 22, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-execution-performance-test Run execution performance test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants