Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Indexer-Grpc-V2] Add implementation for Ping in FN. #15771

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

grao1991
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 17, 2025

@grao1991 grao1991 marked this pull request as ready for review January 18, 2025 03:36
@grao1991 grao1991 enabled auto-merge (squash) January 18, 2025 03:36

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 17540fad8e88ab5681f3a91190b9f5d37e53d2ef ==> ddd7cae2fe38773364ec69dbf5df5291fbc9cc78

Compatibility test results for 17540fad8e88ab5681f3a91190b9f5d37e53d2ef ==> ddd7cae2fe38773364ec69dbf5df5291fbc9cc78 (PR)
1. Check liveness of validators at old version: 17540fad8e88ab5681f3a91190b9f5d37e53d2ef
compatibility::simple-validator-upgrade::liveness-check : committed: 11573.28 txn/s, latency: 2761.70 ms, (p50: 2500 ms, p70: 3100, p90: 3400 ms, p99: 13500 ms), latency samples: 378140
2. Upgrading first Validator to new version: ddd7cae2fe38773364ec69dbf5df5291fbc9cc78
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4208.82 txn/s, latency: 7234.86 ms, (p50: 8100 ms, p70: 8500, p90: 8800 ms, p99: 8900 ms), latency samples: 92200
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4309.53 txn/s, latency: 7884.12 ms, (p50: 8900 ms, p70: 8900, p90: 9200 ms, p99: 9300 ms), latency samples: 152380
3. Upgrading rest of first batch to new version: ddd7cae2fe38773364ec69dbf5df5291fbc9cc78
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4443.24 txn/s, latency: 6983.30 ms, (p50: 7700 ms, p70: 8200, p90: 8600 ms, p99: 8800 ms), latency samples: 92400
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4493.28 txn/s, latency: 7534.11 ms, (p50: 8400 ms, p70: 8500, p90: 8800 ms, p99: 8900 ms), latency samples: 160560
4. upgrading second batch to new version: ddd7cae2fe38773364ec69dbf5df5291fbc9cc78
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7046.25 txn/s, latency: 4290.16 ms, (p50: 4700 ms, p70: 4900, p90: 6000 ms, p99: 6200 ms), latency samples: 133100
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6965.68 txn/s, latency: 4860.75 ms, (p50: 4800 ms, p70: 6000, p90: 6300 ms, p99: 6500 ms), latency samples: 236400
5. check swarm health
Compatibility test for 17540fad8e88ab5681f3a91190b9f5d37e53d2ef ==> ddd7cae2fe38773364ec69dbf5df5291fbc9cc78 passed
Test Ok

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on ddd7cae2fe38773364ec69dbf5df5291fbc9cc78

two traffics test: inner traffic : committed: 15008.16 txn/s, latency: 2640.50 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3100 ms), latency samples: 5706420
two traffics test : committed: 99.97 txn/s, latency: 1430.40 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 1800 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.617, avg: 1.434", "ConsensusProposalToOrdered: max: 0.290, avg: 0.286", "ConsensusOrderedToCommit: max: 0.402, avg: 0.391", "ConsensusProposalToCommit: max: 0.688, avg: 0.677"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.71s no progress at version 267373 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.64s no progress at version 2996104 (avg 0.64s) [limit 16].
Test Ok

@grao1991 grao1991 merged commit 99ac697 into main Jan 21, 2025
46 checks passed
@grao1991 grao1991 deleted the grao_grpc_fn branch January 21, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants