Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move-vm] Increase bytecode VERSION_MAX to v8 #15777

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[move-vm] Increase bytecode VERSION_MAX to v8 #15777

merged 1 commit into from
Jan 22, 2025

Conversation

wrwg
Copy link
Contributor

@wrwg wrwg commented Jan 20, 2025

Description

This creates a lot of diffs in baselines allover the codebase, so putting it into its own PR. No functional change expected, as this only sets VERSION_MAX but not VERSION_DEFAULT, and the bytecode version on chain is furthermore controlled by feature flags.

How Has This Been Tested?

Existing tests

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Copy link

trunk-io bot commented Jan 20, 2025

⏱️ 15h 5m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 6h 55m 🟩🟥🟩🟥🟩 (+14 more)
execution-performance / test-target-determinator 1h 33m 🟩🟩🟩🟩🟩 (+13 more)
test-target-determinator 1h 25m 🟩🟩🟩🟩🟩 (+12 more)
check-dynamic-deps 45m 🟩🟩🟩🟩🟩 (+16 more)
rust-cargo-deny 35m 🟩🟩🟩🟩🟩 (+15 more)
forge-e2e-test / forge 33m 🟥
fetch-last-released-docker-image-tag 27m 🟩🟩🟩🟩🟩 (+12 more)
forge-framework-upgrade-test / forge 14m 🟩
rust-images / rust-all 13m 🟩
forge-e2e-test / forge 13m 🟩
forge-compat-test / forge 12m 🟩
general-lints 9m 🟩🟩🟩🟩🟩 (+15 more)
semgrep/ci 8m 🟩🟩🟩🟩🟩 (+16 more)
rust-doc-tests 7m 🟩
rust-doc-tests 7m 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@wrwg wrwg force-pushed the wrwg/prover-shards branch from ebc35a8 to 5bf5802 Compare January 20, 2025 22:16
@wrwg wrwg force-pushed the wrwg/bv8 branch 2 times, most recently from 5b9ba6a to 60a39f0 Compare January 20, 2025 23:15
@wrwg wrwg force-pushed the wrwg/prover-shards branch 2 times, most recently from afe2d9e to 22a726c Compare January 20, 2025 23:36
@wrwg wrwg added CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR CICD:run-framework-upgrade-test labels Jan 20, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@wrwg wrwg disabled auto-merge January 21, 2025 21:48

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This creates a lot of diffs in baselines allover the codebase, so putting it into its own PR. No functional change expected, as this only sets VERSION_MAX but not VERSION_DEFAULT, and the bytecode version on chain is furthermore controlled by feature flags.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@wrwg wrwg enabled auto-merge (squash) January 21, 2025 23:13

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on bb609ba7417025d8af1e199c345631c8b4b2c412 ==> c9858cc63049812803d0ffd9cce611436879ef98

Compatibility test results for bb609ba7417025d8af1e199c345631c8b4b2c412 ==> c9858cc63049812803d0ffd9cce611436879ef98 (PR)
1. Check liveness of validators at old version: bb609ba7417025d8af1e199c345631c8b4b2c412
compatibility::simple-validator-upgrade::liveness-check : committed: 11298.97 txn/s, latency: 2595.42 ms, (p50: 2100 ms, p70: 2200, p90: 2700 ms, p99: 12200 ms), latency samples: 487620
2. Upgrading first Validator to new version: c9858cc63049812803d0ffd9cce611436879ef98
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4451.32 txn/s, latency: 6919.31 ms, (p50: 8000 ms, p70: 8200, p90: 8400 ms, p99: 8500 ms), latency samples: 100880
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4262.86 txn/s, latency: 7958.59 ms, (p50: 8900 ms, p70: 9000, p90: 9300 ms, p99: 9400 ms), latency samples: 149820
3. Upgrading rest of first batch to new version: c9858cc63049812803d0ffd9cce611436879ef98
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4224.57 txn/s, latency: 7384.35 ms, (p50: 8200 ms, p70: 8700, p90: 9100 ms, p99: 9200 ms), latency samples: 91080
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4123.57 txn/s, latency: 8243.22 ms, (p50: 9200 ms, p70: 9400, p90: 9600 ms, p99: 9800 ms), latency samples: 145400
4. upgrading second batch to new version: c9858cc63049812803d0ffd9cce611436879ef98
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8237.58 txn/s, latency: 3747.13 ms, (p50: 4300 ms, p70: 4600, p90: 4600 ms, p99: 4800 ms), latency samples: 151040
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7971.77 txn/s, latency: 4245.50 ms, (p50: 4600 ms, p70: 4700, p90: 4700 ms, p99: 4800 ms), latency samples: 268980
5. check swarm health
Compatibility test for bb609ba7417025d8af1e199c345631c8b4b2c412 ==> c9858cc63049812803d0ffd9cce611436879ef98 passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on bb609ba7417025d8af1e199c345631c8b4b2c412 ==> c9858cc63049812803d0ffd9cce611436879ef98

Compatibility test results for bb609ba7417025d8af1e199c345631c8b4b2c412 ==> c9858cc63049812803d0ffd9cce611436879ef98 (PR)
Upgrade the nodes to version: c9858cc63049812803d0ffd9cce611436879ef98
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1985.30 txn/s, submitted: 1990.90 txn/s, failed submission: 5.60 txn/s, expired: 5.60 txn/s, latency: 1584.98 ms, (p50: 1500 ms, p70: 1800, p90: 2400 ms, p99: 3400 ms), latency samples: 163081
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1847.80 txn/s, submitted: 1853.77 txn/s, failed submission: 5.97 txn/s, expired: 5.97 txn/s, latency: 1932.69 ms, (p50: 1200 ms, p70: 1500, p90: 2700 ms, p99: 13200 ms), latency samples: 154841
5. check swarm health
Compatibility test for bb609ba7417025d8af1e199c345631c8b4b2c412 ==> c9858cc63049812803d0ffd9cce611436879ef98 passed
Upgrade the remaining nodes to version: c9858cc63049812803d0ffd9cce611436879ef98
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1868.09 txn/s, submitted: 1873.97 txn/s, failed submission: 5.87 txn/s, expired: 5.87 txn/s, latency: 1606.46 ms, (p50: 1500 ms, p70: 1800, p90: 2400 ms, p99: 3400 ms), latency samples: 165401
Test Ok

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c9858cc63049812803d0ffd9cce611436879ef98

two traffics test: inner traffic : committed: 14417.95 txn/s, submitted: 14431.79 txn/s, expired: 13.83 txn/s, latency: 2693.23 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3700 ms), latency samples: 5482040
two traffics test : committed: 99.96 txn/s, latency: 1523.90 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 1800 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.534, avg: 1.423", "ConsensusProposalToOrdered: max: 0.296, avg: 0.294", "ConsensusOrderedToCommit: max: 0.437, avg: 0.426", "ConsensusProposalToCommit: max: 0.731, avg: 0.719"]
Max non-epoch-change gap was: 1 rounds at version 43070 (avg 0.00) [limit 4], 1.79s no progress at version 43070 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.68s no progress at version 2634989 (avg 0.68s) [limit 16].
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR CICD:run-framework-upgrade-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants