Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aptos-vm] Refactor type tag processing #15781

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

georgemitenkov
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 21, 2025

⏱️ 53m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 26m 🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 5m 🟩
check-dynamic-deps 5m 🟩🟩
test-target-determinator 5m 🟩
rust-cargo-deny 3m 🟩🟩
fetch-last-released-docker-image-tag 1m 🟩
general-lints 51s 🟩🟩
semgrep/ci 41s 🟩🟩
file_change_determinator 25s 🟩🟩
file_change_determinator 10s 🟩
permission-check 6s 🟩🟩
permission-check 5s 🟩🟩
determine-docker-build-metadata 3s 🟩
permission-check 2s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 26m 17m +53%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@georgemitenkov georgemitenkov marked this pull request as ready for review January 21, 2025 13:32
Copy link
Contributor

@ziaptos ziaptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also draft a PR that also conditionally enables calltree and instr caches for this (or larger gas version).

@georgemitenkov georgemitenkov enabled auto-merge (squash) January 22, 2025 12:27

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on bb609ba7417025d8af1e199c345631c8b4b2c412 ==> a54566f1b129c67f83cfbad206aac7a811599892

Compatibility test results for bb609ba7417025d8af1e199c345631c8b4b2c412 ==> a54566f1b129c67f83cfbad206aac7a811599892 (PR)
1. Check liveness of validators at old version: bb609ba7417025d8af1e199c345631c8b4b2c412
compatibility::simple-validator-upgrade::liveness-check : committed: 12934.88 txn/s, latency: 2558.59 ms, (p50: 2300 ms, p70: 2500, p90: 3700 ms, p99: 6300 ms), latency samples: 420460
2. Upgrading first Validator to new version: a54566f1b129c67f83cfbad206aac7a811599892
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3965.06 txn/s, latency: 7894.36 ms, (p50: 8700 ms, p70: 9300, p90: 9600 ms, p99: 9800 ms), latency samples: 89240
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3869.78 txn/s, latency: 8879.49 ms, (p50: 9800 ms, p70: 10200, p90: 10400 ms, p99: 10600 ms), latency samples: 138740
3. Upgrading rest of first batch to new version: a54566f1b129c67f83cfbad206aac7a811599892
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4446.21 txn/s, latency: 7018.40 ms, (p50: 7800 ms, p70: 8300, p90: 8700 ms, p99: 8900 ms), latency samples: 93560
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4373.82 txn/s, latency: 7770.61 ms, (p50: 8700 ms, p70: 8800, p90: 9000 ms, p99: 9100 ms), latency samples: 154600
4. upgrading second batch to new version: a54566f1b129c67f83cfbad206aac7a811599892
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7314.87 txn/s, latency: 4154.23 ms, (p50: 4600 ms, p70: 4700, p90: 5800 ms, p99: 6100 ms), latency samples: 135380
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7560.92 txn/s, latency: 4544.18 ms, (p50: 4800 ms, p70: 5200, p90: 5300 ms, p99: 5600 ms), latency samples: 252560
5. check swarm health
Compatibility test for bb609ba7417025d8af1e199c345631c8b4b2c412 ==> a54566f1b129c67f83cfbad206aac7a811599892 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a54566f1b129c67f83cfbad206aac7a811599892

two traffics test: inner traffic : committed: 14650.93 txn/s, latency: 2705.72 ms, (p50: 2600 ms, p70: 2700, p90: 3000 ms, p99: 6000 ms), latency samples: 5570640
two traffics test : committed: 100.01 txn/s, latency: 1924.66 ms, (p50: 1400 ms, p70: 1500, p90: 2300 ms, p99: 22300 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.316, avg: 1.189", "ConsensusProposalToOrdered: max: 0.292, avg: 0.290", "ConsensusOrderedToCommit: max: 0.414, avg: 0.399", "ConsensusProposalToCommit: max: 0.704, avg: 0.688"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.02s no progress at version 31857 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.84s no progress at version 6311457 (avg 0.72s) [limit 16].
Test Ok

@georgemitenkov georgemitenkov merged commit 4e5f578 into main Jan 22, 2025
90 checks passed
@georgemitenkov georgemitenkov deleted the george/gas-for-tags branch January 22, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants