qs: undo using block votes to fetch batches

[ibalajiarun]

Description

Basically, get_transactions is not cancellation safe, so it cannot be polled in a select statement.

[trunk-io]

⏱️ 2h 5m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
test-target-determinator	24m	🟩 ⬜ 🟩 🟩 🟩 (+2 more)
check-dynamic-deps	22m	🟩 🟩 🟩 🟩 🟩 (+4 more)
execution-performance / test-target-determinator	14m	🟩 🟩 🟩
forge-compat-test / forge	13m	🟩
forge-e2e-test / forge	13m	🟩
rust-cargo-deny	12m	🟩 🟩 🟩 🟩 🟩 (+3 more)
rust-doc-tests	6m	🟩
rust-doc-tests	5m	🟥
fetch-last-released-docker-image-tag	5m	🟩 🟩 🟩
semgrep/ci	3m	🟩 🟩 🟩 🟩 🟩 (+4 more)
general-lints	3m	🟩 🟩 🟩 🟩 🟩 (+3 more)
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+4 more)
file_change_determinator	1m	🟩 ⬜ 🟩 🟩 🟩 (+2 more)
Backport PR	35s	🟩
execution-performance / single-node-performance	31s	🟩 🟩 🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite realistic_env_max_load success on 907785bd0459073468f6a4f9ffb35f176397cf85

two traffics test: inner traffic : committed: 14496.06 txn/s, latency: 2736.34 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 4500 ms), latency samples: 5511700
two traffics test : committed: 99.99 txn/s, latency: 1433.83 ms, (p50: 1400 ms, p70: 1500, p90: 1500 ms, p99: 1800 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.575, avg: 1.438", "ConsensusProposalToOrdered: max: 0.295, avg: 0.290", "ConsensusOrderedToCommit: max: 0.420, avg: 0.394", "ConsensusProposalToCommit: max: 0.710, avg: 0.684"]
Max non-epoch-change gap was: 1 rounds at version 5751511 (avg 0.00) [limit 4], 1.92s no progress at version 5751511 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.65s no progress at version 2835080 (avg 0.65s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on bb609ba7417025d8af1e199c345631c8b4b2c412 ==> 907785bd0459073468f6a4f9ffb35f176397cf85

Compatibility test results for bb609ba7417025d8af1e199c345631c8b4b2c412 ==> 907785bd0459073468f6a4f9ffb35f176397cf85 (PR)
1. Check liveness of validators at old version: bb609ba7417025d8af1e199c345631c8b4b2c412
compatibility::simple-validator-upgrade::liveness-check : committed: 8472.38 txn/s, latency: 3183.34 ms, (p50: 2300 ms, p70: 2700, p90: 6800 ms, p99: 13700 ms), latency samples: 348140
2. Upgrading first Validator to new version: 907785bd0459073468f6a4f9ffb35f176397cf85
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4183.23 txn/s, latency: 7458.84 ms, (p50: 8200 ms, p70: 8800, p90: 9100 ms, p99: 9200 ms), latency samples: 90540
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4149.69 txn/s, latency: 8194.90 ms, (p50: 9200 ms, p70: 9300, p90: 9400 ms, p99: 9600 ms), latency samples: 145980
3. Upgrading rest of first batch to new version: 907785bd0459073468f6a4f9ffb35f176397cf85
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4092.09 txn/s, latency: 7670.50 ms, (p50: 8500 ms, p70: 9000, p90: 9400 ms, p99: 9600 ms), latency samples: 90400
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4096.34 txn/s, latency: 8332.39 ms, (p50: 9300 ms, p70: 9500, p90: 9700 ms, p99: 9800 ms), latency samples: 144500
4. upgrading second batch to new version: 907785bd0459073468f6a4f9ffb35f176397cf85
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7542.55 txn/s, latency: 4055.82 ms, (p50: 4600 ms, p70: 4800, p90: 5400 ms, p99: 5600 ms), latency samples: 140480
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7479.15 txn/s, latency: 4556.76 ms, (p50: 4800 ms, p70: 5300, p90: 5600 ms, p99: 5800 ms), latency samples: 250760
5. check swarm health
Compatibility test for bb609ba7417025d8af1e199c345631c8b4b2c412 ==> 907785bd0459073468f6a4f9ffb35f176397cf85 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

💚 All backports created successfully

Status	Branch	Result
✅	aptos-release-v1.26

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details