Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change big_ordered_map::Node to enum for easier maintanability #15787

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Change big_ordered_map::Node to enum for easier maintanability #15787

merged 2 commits into from
Jan 23, 2025

Conversation

igor-aptos
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@igor-aptos igor-aptos added the CICD:run-execution-performance-test Run execution performance test label Jan 22, 2025
@trunk-io Trunk.io
Copy link

trunk-io bot commented Jan 22, 2025 •
edited
Loading

⏱️ 4h 21m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 2h 7m 🟩 🟩 🟥 🟩 🟩 (+1 more)
rust-smoke-tests 31m 🟩 
execution-performance / test-target-determinator 30m 🟩 🟩 🟩 🟩 🟩 (+1 more)
test-target-determinator 21m 🟩 🟩 ⬜ 🟩 🟩 
check-dynamic-deps 15m 🟩 🟩 🟩 🟩 🟩 (+1 more)
forge-e2e-test / forge 13m 🟩 
rust-cargo-deny 9m 🟩 🟩 🟩 🟩 🟩 
rust-doc-tests 5m 🟩 
general-lints 2m 🟩 🟩 🟩 🟩 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 🟩 (+1 more)
fetch-last-released-docker-image-tag 2m 🟩 
file_change_determinator 58s 🟩 🟩 🟩 🟩 🟩 
file_change_determinator 50s 🟩 🟩 🟩 🟩 🟩 (+1 more)
Backport PR 35s 🟩 
permission-check 15s 🟩 🟩 🟩 🟩 🟩 (+1 more)

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@igor-aptos igor-aptos force-pushed the igor/big_ordered_map_node_enum branch from 499a94e to c8d87ad Compare January 23, 2025 01:51
@igor-aptos igor-aptos enabled auto-merge (squash) January 23, 2025 02:53
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on c6ca872f3c6191f38cb164a37f8e23db398f068e ==> c8d87ad6228dd189b5f031e4513edc3796a80f3c

Compatibility test results for c6ca872f3c6191f38cb164a37f8e23db398f068e ==> c8d87ad6228dd189b5f031e4513edc3796a80f3c (PR)
1. Check liveness of validators at old version: c6ca872f3c6191f38cb164a37f8e23db398f068e
compatibility::simple-validator-upgrade::liveness-check : committed: 13384.79 txn/s, latency: 2394.79 ms, (p50: 2100 ms, p70: 2900, p90: 3200 ms, p99: 4900 ms), latency samples: 433160
2. Upgrading first Validator to new version: c8d87ad6228dd189b5f031e4513edc3796a80f3c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3901.61 txn/s, latency: 7911.75 ms, (p50: 8600 ms, p70: 9400, p90: 9900 ms, p99: 10000 ms), latency samples: 86680
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3871.53 txn/s, latency: 8828.17 ms, (p50: 9800 ms, p70: 9900, p90: 10200 ms, p99: 10400 ms), latency samples: 137600
3. Upgrading rest of first batch to new version: c8d87ad6228dd189b5f031e4513edc3796a80f3c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4229.46 txn/s, latency: 7357.35 ms, (p50: 8100 ms, p70: 8700, p90: 9000 ms, p99: 9100 ms), latency samples: 91040
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4211.63 txn/s, latency: 8080.13 ms, (p50: 9100 ms, p70: 9100, p90: 9500 ms, p99: 9500 ms), latency samples: 148280
4. upgrading second batch to new version: c8d87ad6228dd189b5f031e4513edc3796a80f3c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7251.45 txn/s, latency: 4190.54 ms, (p50: 4600 ms, p70: 4900, p90: 5600 ms, p99: 6000 ms), latency samples: 137680
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7197.02 txn/s, latency: 4715.43 ms, (p50: 4800 ms, p70: 5500, p90: 5900 ms, p99: 6300 ms), latency samples: 246120
5. check swarm health
Compatibility test for c6ca872f3c6191f38cb164a37f8e23db398f068e ==> c8d87ad6228dd189b5f031e4513edc3796a80f3c passed
Test Ok

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c8d87ad6228dd189b5f031e4513edc3796a80f3c

two traffics test: inner traffic : committed: 14898.27 txn/s, latency: 2661.00 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3300 ms), latency samples: 5664680
two traffics test : committed: 99.98 txn/s, latency: 1417.56 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 1900 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.491, avg: 1.414", "ConsensusProposalToOrdered: max: 0.288, avg: 0.285", "ConsensusOrderedToCommit: max: 0.403, avg: 0.386", "ConsensusProposalToCommit: max: 0.689, avg: 0.671"]
Max non-epoch-change gap was: 1 rounds at version 6266049 (avg 0.00) [limit 4], 1.85s no progress at version 6266049 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.75s no progress at version 2948860 (avg 0.75s) [limit 16].
Test Ok

@igor-aptos igor-aptos merged commit 8bff8d0 into main Jan 23, 2025
124 of 137 checks passed
@igor-aptos igor-aptos deleted the igor/big_ordered_map_node_enum branch January 23, 2025 07:04
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
@igor-aptos
Change big_ordered_map::Node to enum for easier maintanability (#15787)
0a3a36f 
* Change big_ordered_map::Node to enum for easier maintanability

* update new_with_config and allocate_spare_slots api to BigOrderedMap

---------

Co-authored-by: Igor <[email protected]>
(cherry picked from commit 8bff8d0)

# Conflicts:
#	crates/transaction-workloads-lib/src/raw_module_data.rs
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ aptos-release-v1.26

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

igor-aptos added a commit that referenced this pull request Jan 23, 2025
@github-actions @igor-aptos
[cp][aptos-release-v1.26] Change big_ordered_map::Node to enum for ea…
d15fc96 
…sier maintanability (#15797)

* Change big_ordered_map::Node to enum for easier maintanability (#15787)

* Change big_ordered_map::Node to enum for easier maintanability

* update new_with_config and allocate_spare_slots api to BigOrderedMap

---------

Co-authored-by: Igor <[email protected]>
(cherry picked from commit 8bff8d0)

# Conflicts:
#	crates/transaction-workloads-lib/src/raw_module_data.rs

* rebase artifact.

public(friend) to ordered_map function

---------

Co-authored-by: igor-aptos <[email protected]>
Co-authored-by: Igor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightmark lightmark lightmark approved these changes

@runtian-zhou runtian-zhou runtian-zhou approved these changes

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

Assignees
No one assigned
Labels
CICD:run-execution-performance-test Run execution performance test v1.26
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-aptos @lightmark @runtian-zhou