Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow that monitors the downstream test result. #15793

Merged

Conversation

larry-aptos
Copy link
Contributor

@larry-aptos larry-aptos commented Jan 22, 2025

Description

Fix the workflow that doesn't catch the downstream workflow breakage. Now processor linter issue will break aptos-core CI!

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 22, 2025

⏱️ 58m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
check-dynamic-deps 10m 🟩🟩🟩🟩🟩
test-target-determinator 10m 🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
general-lints 2m 🟩🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
file_change_determinator 53s 🟩🟩🟩🟩🟩
file_change_determinator 24s 🟩🟩
execution-performance / single-node-performance 19s 🟩🟩
permission-check 12s 🟩🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩
determine-docker-build-metadata 6s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 17m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@larry-aptos larry-aptos marked this pull request as ready for review January 22, 2025 19:33
@larry-aptos larry-aptos requested a review from a team as a code owner January 22, 2025 19:33
Copy link
Contributor Author

larry-aptos commented Jan 22, 2025

@larry-aptos larry-aptos force-pushed the 01-22-add_workflow_that_monitors_the_downstream_test_result branch from 45c6902 to a5671ff Compare January 22, 2025 19:36
@larry-aptos larry-aptos force-pushed the 01-22-add_workflow_that_monitors_the_downstream_test_result branch from a5671ff to b666486 Compare January 22, 2025 19:40
@larry-aptos larry-aptos requested a review from a team January 22, 2025 19:49
@larry-aptos larry-aptos enabled auto-merge (squash) January 23, 2025 01:12

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@yuunlimm yuunlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@larry-aptos larry-aptos force-pushed the 01-22-add_workflow_that_monitors_the_downstream_test_result branch from b666486 to 5860402 Compare January 23, 2025 21:37

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 9e7cf4a27cc20504cee5ffefc35bd8e7792dde36 ==> 586040287502a05e29a565e15bdb8898896d2072

Compatibility test results for 9e7cf4a27cc20504cee5ffefc35bd8e7792dde36 ==> 586040287502a05e29a565e15bdb8898896d2072 (PR)
1. Check liveness of validators at old version: 9e7cf4a27cc20504cee5ffefc35bd8e7792dde36
compatibility::simple-validator-upgrade::liveness-check : committed: 12724.37 txn/s, latency: 2504.46 ms, (p50: 2500 ms, p70: 2700, p90: 3100 ms, p99: 3700 ms), latency samples: 418360
2. Upgrading first Validator to new version: 586040287502a05e29a565e15bdb8898896d2072
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4020.47 txn/s, latency: 7786.36 ms, (p50: 8500 ms, p70: 9100, p90: 9400 ms, p99: 9500 ms), latency samples: 89000
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3808.35 txn/s, latency: 8872.28 ms, (p50: 9800 ms, p70: 9900, p90: 10300 ms, p99: 10400 ms), latency samples: 139380
3. Upgrading rest of first batch to new version: 586040287502a05e29a565e15bdb8898896d2072
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4373.45 txn/s, latency: 7100.37 ms, (p50: 7900 ms, p70: 8500, p90: 8700 ms, p99: 9000 ms), latency samples: 93100
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4367.16 txn/s, latency: 7786.15 ms, (p50: 8800 ms, p70: 8800, p90: 9100 ms, p99: 9200 ms), latency samples: 153520
4. upgrading second batch to new version: 586040287502a05e29a565e15bdb8898896d2072
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7896.27 txn/s, latency: 3918.47 ms, (p50: 4600 ms, p70: 4700, p90: 4900 ms, p99: 5100 ms), latency samples: 148580
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7960.86 txn/s, latency: 4314.16 ms, (p50: 4700 ms, p70: 4800, p90: 5100 ms, p99: 5100 ms), latency samples: 267220
5. check swarm health
Compatibility test for 9e7cf4a27cc20504cee5ffefc35bd8e7792dde36 ==> 586040287502a05e29a565e15bdb8898896d2072 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 586040287502a05e29a565e15bdb8898896d2072

two traffics test: inner traffic : committed: 14656.67 txn/s, latency: 2703.09 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3500 ms), latency samples: 5572760
two traffics test : committed: 100.00 txn/s, latency: 1462.01 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 3300 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.454, avg: 1.416", "ConsensusProposalToOrdered: max: 0.309, avg: 0.294", "ConsensusOrderedToCommit: max: 0.424, avg: 0.409", "ConsensusProposalToCommit: max: 0.715, avg: 0.702"]
Max non-epoch-change gap was: 1 rounds at version 27095 (avg 0.00) [limit 4], 2.28s no progress at version 27095 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.68s no progress at version 2446624 (avg 0.68s) [limit 16].
Test Ok

@larry-aptos larry-aptos merged commit 3722b6e into main Jan 23, 2025
46 checks passed
@larry-aptos larry-aptos deleted the 01-22-add_workflow_that_monitors_the_downstream_test_result branch January 23, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants