Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Terraform & Helm #15795

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Sync Terraform & Helm #15795

merged 1 commit into from
Jan 24, 2025

Conversation

sionescu
Copy link
Contributor

Sync Terraform & Helm changes

@trunk-io Trunk.io
Copy link

trunk-io bot commented Jan 22, 2025 •
edited
Loading

⏱️ 1h 43m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / test-target-determinator 19m 🟩 🟩 🟩 🟩 
test-target-determinator 17m 🟩 🟩 ⬜ 🟩 
forge-e2e-test / forge 13m 🟩 
check-dynamic-deps 12m 🟩 🟩 🟩 🟩 🟩 
rust-cargo-deny 9m 🟩 🟩 🟩 🟩 🟩 
fetch-last-released-docker-image-tag 6m 🟩 🟩 🟩 🟩 
rust-doc-tests 5m 🟩 
rust-doc-tests 5m 🟩 
rust-doc-tests 5m 🟩 
rust-doc-tests 3m ⬜ 
general-lints 2m 🟩 🟩 🟩 🟩 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 🟩 
file_change_determinator 58s 🟩 🟩 🟩 🟩 🟩 
file_change_determinator 45s 🟩 🟩 🟩 🟩 
execution-performance / single-node-performance 42s 🟩 🟩 🟩 🟩 

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 17m -99%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@sionescu sionescu marked this pull request as ready for review January 22, 2025 23:13
@sionescu sionescu requested a review from a team as a code owner January 22, 2025 23:13
@sionescu sionescu requested review from areshand and grao1991 January 22, 2025 23:16
@sionescu sionescu enabled auto-merge (rebase) January 22, 2025 23:36
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
perryjrandall
perryjrandall reviewed Jan 23, 2025
View reviewed changes
terraform/helm/aptos-node/files/configs/fullnode-base.yaml Outdated
@@ -11,8 +11,6 @@ execution:
genesis_file_location: /opt/aptos/genesis/genesis.blob

storage:
rocksdb_configs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are removing this? will this disable sharding?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like that would undo this

8f5b5b2

perryjrandall
perryjrandall requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@perryjrandall perryjrandall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it might disable sharding on fullnodes?

also forge failed so please dont merge this until forge itself is passing

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@sionescu sionescu force-pushed the sync_terraform_helm branch from 15f3f61 to 42ebf6a Compare January 24, 2025 01:35
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@sionescu sionescu force-pushed the sync_terraform_helm branch from 42ebf6a to 342d078 Compare January 24, 2025 17:24
@sionescu
Sync Terraform & Helm changes
532ae79 
GitOrigin-RevId: 79f4d473a837aabd9ffa7f7b1646c5e6e9427de2
@sionescu sionescu force-pushed the sync_terraform_helm branch from 342d078 to 532ae79 Compare January 24, 2025 17:27
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 532ae7993518d23de93e257645e3e9f878461393

two traffics test: inner traffic : committed: 14505.81 txn/s, latency: 2731.46 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5515480
two traffics test : committed: 100.00 txn/s, latency: 1412.52 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 1700 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.531, avg: 1.475", "ConsensusProposalToOrdered: max: 0.304, avg: 0.294", "ConsensusOrderedToCommit: max: 0.419, avg: 0.401", "ConsensusProposalToCommit: max: 0.714, avg: 0.695"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.52s no progress at version 31107 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.72s no progress at version 2673731 (avg 0.72s) [limit 16].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on d15fc969c89551a1461d931d327b8d4dbfb2f814 ==> 532ae7993518d23de93e257645e3e9f878461393

Compatibility test results for d15fc969c89551a1461d931d327b8d4dbfb2f814 ==> 532ae7993518d23de93e257645e3e9f878461393 (PR)
1. Check liveness of validators at old version: d15fc969c89551a1461d931d327b8d4dbfb2f814
compatibility::simple-validator-upgrade::liveness-check : committed: 11835.67 txn/s, latency: 2698.98 ms, (p50: 2400 ms, p70: 2800, p90: 3800 ms, p99: 6600 ms), latency samples: 421360
2. Upgrading first Validator to new version: 532ae7993518d23de93e257645e3e9f878461393
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3586.33 txn/s, latency: 8475.72 ms, (p50: 9200 ms, p70: 9800, p90: 10400 ms, p99: 10600 ms), latency samples: 81240
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3797.38 txn/s, latency: 9043.24 ms, (p50: 10000 ms, p70: 10100, p90: 10300 ms, p99: 10600 ms), latency samples: 135200
3. Upgrading rest of first batch to new version: 532ae7993518d23de93e257645e3e9f878461393
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4507.86 txn/s, latency: 6899.32 ms, (p50: 7600 ms, p70: 8300, p90: 8600 ms, p99: 8700 ms), latency samples: 93860
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4399.32 txn/s, latency: 7731.57 ms, (p50: 8500 ms, p70: 8600, p90: 8700 ms, p99: 9100 ms), latency samples: 156480
4. upgrading second batch to new version: 532ae7993518d23de93e257645e3e9f878461393
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8177.02 txn/s, latency: 3741.97 ms, (p50: 4400 ms, p70: 4600, p90: 4900 ms, p99: 5100 ms), latency samples: 149480
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8132.87 txn/s, latency: 4128.07 ms, (p50: 4500 ms, p70: 4700, p90: 4900 ms, p99: 5200 ms), latency samples: 271120
5. check swarm health
Compatibility test for d15fc969c89551a1461d931d327b8d4dbfb2f814 ==> 532ae7993518d23de93e257645e3e9f878461393 passed
Test Ok

@sionescu sionescu disabled auto-merge January 24, 2025 18:04
@sionescu sionescu merged commit 6705ea5 into main Jan 24, 2025
46 of 47 checks passed
@sionescu sionescu deleted the sync_terraform_helm branch January 24, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perryjrandall perryjrandall perryjrandall requested changes

@areshand areshand areshand approved these changes

@grao1991 grao1991 grao1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sionescu @areshand @grao1991 @perryjrandall