Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new test cases to validate fa bug fix #15897

Merged
merged 2 commits into from
Feb 12, 2025
Merged

add new test cases to validate fa bug fix #15897

merged 2 commits into from
Feb 12, 2025

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Feb 6, 2025

Description

add new test cases to validate fa bug fix

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Sorry, something went wrong.

Copy link

trunk-io bot commented Feb 6, 2025

⏱️ 2h 3m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-smoke-tests 36m 🟩
dispatch_event 15m 🟥🟩
test-target-determinator 14m 🟩🟩🟩
execution-performance / test-target-determinator 14m 🟩🟩🟩
check-dynamic-deps 8m 🟩🟩🟩🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
rust-doc-tests 7m 🟩
rust-doc-tests 6m 🟩
rust-doc-tests 6m 🟩
fetch-last-released-docker-image-tag 5m 🟩🟩🟩
general-lints 2m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 44s 🟩🟩🟩🟩
file_change_determinator 38s 🟩🟩🟩
execution-performance / single-node-performance 31s 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 1m 2m -44%

settingsfeedbackdocs ⋅ learn more about trunk.io

@yuunlimm yuunlimm enabled auto-merge (squash) February 6, 2025 21:30

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

✅ Forge suite realistic_env_max_load success on 6f64aea8e5aba9207ffce13060b8bdd031a8de31

two traffics test: inner traffic : committed: 12246.61 txn/s, submitted: 12273.23 txn/s, expired: 26.62 txn/s, latency: 3110.54 ms, (p50: 2700 ms, p70: 3000, p90: 3900 ms, p99: 10400 ms), latency samples: 4656460
two traffics test : committed: 99.99 txn/s, latency: 1799.40 ms, (p50: 1500 ms, p70: 1700, p90: 2200 ms, p99: 6500 ms), latency samples: 1880
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.743, avg: 1.493", "ConsensusProposalToOrdered: max: 0.340, avg: 0.328", "ConsensusOrderedToCommit: max: 0.759, avg: 0.577", "ConsensusProposalToCommit: max: 1.099, avg: 0.905"]
Max non-epoch-change gap was: 1 rounds at version 2504642 (avg 0.00) [limit 4], 2.10s no progress at version 2507612 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.74s no progress at version 2391318 (avg 0.74s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Feb 7, 2025

✅ Forge suite compat success on 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 6f64aea8e5aba9207ffce13060b8bdd031a8de31

Compatibility test results for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 6f64aea8e5aba9207ffce13060b8bdd031a8de31 (PR)
1. Check liveness of validators at old version: 255673e8f2757ed8634a7d65d7aca11de7016cde
compatibility::simple-validator-upgrade::liveness-check : committed: 12242.47 txn/s, latency: 2670.43 ms, (p50: 2700 ms, p70: 2900, p90: 3300 ms, p99: 4400 ms), latency samples: 408260
2. Upgrading first Validator to new version: 6f64aea8e5aba9207ffce13060b8bdd031a8de31
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3266.96 txn/s, latency: 8964.19 ms, (p50: 9600 ms, p70: 10900, p90: 11600 ms, p99: 11800 ms), latency samples: 70780
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3305.66 txn/s, latency: 10441.76 ms, (p50: 11300 ms, p70: 11800, p90: 12000 ms, p99: 12100 ms), latency samples: 127000
3. Upgrading rest of first batch to new version: 6f64aea8e5aba9207ffce13060b8bdd031a8de31
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 966.48 txn/s, submitted: 966.62 txn/s, expired: 0.14 txn/s, latency: 8898.45 ms, (p50: 9600 ms, p70: 10700, p90: 11400 ms, p99: 11600 ms), latency samples: 73569
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3331.14 txn/s, latency: 10342.30 ms, (p50: 11400 ms, p70: 11600, p90: 11800 ms, p99: 11900 ms), latency samples: 127460
4. upgrading second batch to new version: 6f64aea8e5aba9207ffce13060b8bdd031a8de31
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6372.41 txn/s, latency: 4778.11 ms, (p50: 5600 ms, p70: 6000, p90: 6000 ms, p99: 6100 ms), latency samples: 119060
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6059.71 txn/s, latency: 5649.30 ms, (p50: 6100 ms, p70: 6400, p90: 6900 ms, p99: 7300 ms), latency samples: 208380
5. check swarm health
Compatibility test for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 6f64aea8e5aba9207ffce13060b8bdd031a8de31 passed
Test Ok

@yuunlimm yuunlimm changed the title Yl/new test add new test cases to validate fa bug fix Feb 10, 2025
@yuunlimm yuunlimm merged commit d7039c3 into main Feb 12, 2025
184 of 185 checks passed
@yuunlimm yuunlimm deleted the yl/new_test branch February 12, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants