[compiler-v2] Dismantle compiler v1

[vineethk]

Description

In this PR, we dismantle compiler v1 and remove unused parts of it. We keep the parser and expansion phase, and a few other pieces used elsewhere, but all the remaining compiler phases are now gone. This results in various simplifications and cleanups.

How Has This Been Tested?

Existing tests.

Key Areas to Review

It might be good to look at the changes other than the files removed completely (i.e., looking at the modifications).

Type of Change

• Refactoring

Which Components or Systems Does This Change Impact?

• Move Compiler

[trunk-io]

⏱️ 1h 22m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	26m	🟩
check-dynamic-deps	17m	🟩 🟩 🟩 🟩 🟩 (+2 more)
rust-cargo-deny	12m	🟩 🟩 🟩 🟩 🟩 (+2 more)
rust-doc-tests	8m	🟩
test-target-determinator	5m	🟩
execution-performance / test-target-determinator	5m	🟩
general-lints	3m	🟩 🟩 🟩 🟩 🟩 (+2 more)
semgrep/ci	3m	🟩 🟩 🟩 🟩 🟩 (+2 more)
fetch-last-released-docker-image-tag	2m	🟩
file_change_determinator	1m	🟩 🟩 🟩 🟩 🟩 (+2 more)
permission-check	18s	🟩 🟩 🟩 🟩 🟩 (+2 more)
permission-check	17s	🟩 🟩 🟩 🟩 🟩 (+2 more)
file_change_determinator	14s	🟩
permission-check	4s	🟩
determine-docker-build-metadata	3s	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	26m	20m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[vineethk]

• [compiler-v2] Dismantle compiler v1 #16094 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

✅ Forge suite realistic_env_max_load success on 3a5d27b6457a6e7867772c701059c2374f403ba5

two traffics test: inner traffic : committed: 12119.77 txn/s, submitted: 12137.54 txn/s, expired: 17.78 txn/s, latency: 3213.98 ms, (p50: 3000 ms, p70: 3300, p90: 3600 ms, p99: 6700 ms), latency samples: 4608200
two traffics test : committed: 99.98 txn/s, latency: 1427.63 ms, (p50: 1400 ms, p70: 1500, p90: 1800 ms, p99: 2300 ms), latency samples: 1900
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.966, avg: 1.852", "ConsensusProposalToOrdered: max: 0.320, avg: 0.316", "ConsensusOrderedToCommit: max: 0.460, avg: 0.414", "ConsensusProposalToCommit: max: 0.773, avg: 0.730"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.94s no progress at version 2403389 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.92s no progress at version 2388716 (avg 0.92s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 3a5d27b6457a6e7867772c701059c2374f403ba5

Compatibility test results for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 3a5d27b6457a6e7867772c701059c2374f403ba5 (PR)
1. Check liveness of validators at old version: c5eef1450476a6f7eee96d0d1953b65df04fdb91
compatibility::simple-validator-upgrade::liveness-check : committed: 11127.64 txn/s, latency: 2833.64 ms, (p50: 2900 ms, p70: 3100, p90: 3500 ms, p99: 4400 ms), latency samples: 381720
2. Upgrading first Validator to new version: 3a5d27b6457a6e7867772c701059c2374f403ba5
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2653.10 txn/s, latency: 10110.16 ms, (p50: 11100 ms, p70: 11400, p90: 11600 ms, p99: 13100 ms), latency samples: 56440
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2569.95 txn/s, latency: 12840.50 ms, (p50: 13600 ms, p70: 14000, p90: 16300 ms, p99: 17100 ms), latency samples: 101220
3. Upgrading rest of first batch to new version: 3a5d27b6457a6e7867772c701059c2374f403ba5
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3161.07 txn/s, latency: 8917.05 ms, (p50: 9000 ms, p70: 11700, p90: 12000 ms, p99: 12100 ms), latency samples: 62480
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2559.38 txn/s, latency: 12260.43 ms, (p50: 10100 ms, p70: 17200, p90: 17800 ms, p99: 18200 ms), latency samples: 90380
4. upgrading second batch to new version: 3a5d27b6457a6e7867772c701059c2374f403ba5
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 5062.96 txn/s, latency: 6007.15 ms, (p50: 6800 ms, p70: 7400, p90: 7900 ms, p99: 8100 ms), latency samples: 101640
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2951.26 txn/s, submitted: 2951.43 txn/s, expired: 0.18 txn/s, latency: 6901.51 ms, (p50: 7500 ms, p70: 7800, p90: 8400 ms, p99: 9100 ms), latency samples: 181969
5. check swarm health
Compatibility test for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 3a5d27b6457a6e7867772c701059c2374f403ba5 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 3a5d27b6457a6e7867772c701059c2374f403ba5

Compatibility test results for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 3a5d27b6457a6e7867772c701059c2374f403ba5 (PR)
Upgrade the nodes to version: 3a5d27b6457a6e7867772c701059c2374f403ba5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 330.18 txn/s, submitted: 330.63 txn/s, failed submission: 0.45 txn/s, expired: 0.45 txn/s, latency: 9240.67 ms, (p50: 6900 ms, p70: 14000, p90: 18400 ms, p99: 20800 ms), latency samples: 29201
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 588.60 txn/s, submitted: 589.48 txn/s, failed submission: 0.88 txn/s, expired: 0.88 txn/s, latency: 5051.21 ms, (p50: 1800 ms, p70: 2300, p90: 19800 ms, p99: 21300 ms), latency samples: 53380
5. check swarm health
Compatibility test for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 3a5d27b6457a6e7867772c701059c2374f403ba5 passed
Upgrade the remaining nodes to version: 3a5d27b6457a6e7867772c701059c2374f403ba5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1699.09 txn/s, submitted: 1701.76 txn/s, failed submission: 2.68 txn/s, expired: 2.68 txn/s, latency: 1784.49 ms, (p50: 1500 ms, p70: 2100, p90: 2700 ms, p99: 3600 ms), latency samples: 152421
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking