Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick recent fixes (main) #16105

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Conversation

vgao1996
Copy link
Contributor

No description provided.

Copy link

trunk-io bot commented Mar 11, 2025

⏱️ 1h 25m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 56m 🟥🟩
check-dynamic-deps 8m 🟩🟩
rust-doc-tests 6m 🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
rust-cargo-deny 3m 🟩🟩
fetch-last-released-docker-image-tag 1m 🟩
general-lints 56s 🟩🟩
semgrep/ci 47s 🟩🟩
file_change_determinator 20s 🟩🟩
file_change_determinator 13s 🟩
permission-check 8s 🟩🟩
permission-check 5s 🟩🟩
determine-docker-build-metadata 3s 🟩
permission-check 2s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 26m 19m +32%

settingsfeedbackdocs ⋅ learn more about trunk.io

@vgao1996 vgao1996 changed the title cherry-pick recent fixes cherry-pick recent fixes (main) Mar 11, 2025
@vgao1996 vgao1996 enabled auto-merge (squash) March 11, 2025 22:20

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on e085ce6848c5602fda8ab1b59ac07f97aceb2ebc

two traffics test: inner traffic : committed: 11985.46 txn/s, submitted: 11996.04 txn/s, expired: 10.57 txn/s, latency: 3261.84 ms, (p50: 2700 ms, p70: 3000, p90: 3300 ms, p99: 12100 ms), latency samples: 4557220
two traffics test : committed: 99.99 txn/s, latency: 3385.21 ms, (p50: 1600 ms, p70: 2300, p90: 10500 ms, p99: 14400 ms), latency samples: 1840
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.453, avg: 1.134", "ConsensusProposalToOrdered: max: 0.326, avg: 0.320", "ConsensusOrderedToCommit: max: 0.413, avg: 0.381", "ConsensusProposalToCommit: max: 0.731, avg: 0.701"]
Max non-epoch-change gap was: 1 rounds at version 2089493 (avg 0.00) [limit 4], 1.82s no progress at version 2089493 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.56s no progress at version 2083086 (avg 0.56s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e085ce6848c5602fda8ab1b59ac07f97aceb2ebc

Compatibility test results for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e085ce6848c5602fda8ab1b59ac07f97aceb2ebc (PR)
1. Check liveness of validators at old version: c5eef1450476a6f7eee96d0d1953b65df04fdb91
compatibility::simple-validator-upgrade::liveness-check : committed: 11238.02 txn/s, latency: 2842.48 ms, (p50: 2700 ms, p70: 2900, p90: 3800 ms, p99: 6500 ms), latency samples: 374200
2. Upgrading first Validator to new version: e085ce6848c5602fda8ab1b59ac07f97aceb2ebc
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2765.40 txn/s, latency: 10505.85 ms, (p50: 10800 ms, p70: 13700, p90: 14100 ms, p99: 14200 ms), latency samples: 63760
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2685.79 txn/s, latency: 11336.68 ms, (p50: 12100 ms, p70: 12500, p90: 13200 ms, p99: 14700 ms), latency samples: 104300
3. Upgrading rest of first batch to new version: e085ce6848c5602fda8ab1b59ac07f97aceb2ebc
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 1449.46 txn/s, latency: 16533.30 ms, (p50: 20100 ms, p70: 23100, p90: 23900 ms, p99: 24200 ms), latency samples: 50900
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2173.90 txn/s, latency: 13786.88 ms, (p50: 14800 ms, p70: 18000, p90: 20200 ms, p99: 20500 ms), latency samples: 74740
4. upgrading second batch to new version: e085ce6848c5602fda8ab1b59ac07f97aceb2ebc
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 872.34 txn/s, latency: 37557.55 ms, (p50: 39200 ms, p70: 39800, p90: 42100 ms, p99: 43400 ms), latency samples: 40040
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5051.30 txn/s, latency: 6636.13 ms, (p50: 6900 ms, p70: 7700, p90: 8100 ms, p99: 8400 ms), latency samples: 181600
5. check swarm health
Compatibility test for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e085ce6848c5602fda8ab1b59ac07f97aceb2ebc passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e085ce6848c5602fda8ab1b59ac07f97aceb2ebc

Compatibility test results for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e085ce6848c5602fda8ab1b59ac07f97aceb2ebc (PR)
Upgrade the nodes to version: e085ce6848c5602fda8ab1b59ac07f97aceb2ebc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 967.79 txn/s, submitted: 969.99 txn/s, failed submission: 2.20 txn/s, expired: 2.20 txn/s, latency: 3305.27 ms, (p50: 3000 ms, p70: 3600, p90: 6100 ms, p99: 8800 ms), latency samples: 87920
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 994.36 txn/s, submitted: 998.78 txn/s, failed submission: 4.42 txn/s, expired: 4.42 txn/s, latency: 3029.23 ms, (p50: 1800 ms, p70: 3700, p90: 5700 ms, p99: 9600 ms), latency samples: 90041
5. check swarm health
Compatibility test for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e085ce6848c5602fda8ab1b59ac07f97aceb2ebc passed
Upgrade the remaining nodes to version: e085ce6848c5602fda8ab1b59ac07f97aceb2ebc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 967.39 txn/s, submitted: 970.66 txn/s, failed submission: 3.27 txn/s, expired: 3.27 txn/s, latency: 3738.69 ms, (p50: 1500 ms, p70: 1800, p90: 12200 ms, p99: 17200 ms), latency samples: 82881
Test Ok

@vgao1996 vgao1996 merged commit 37bc7b8 into aptos-labs:main Mar 11, 2025
84 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants