Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move-vm] Representation of field borrow labels (#16102) #16106

Merged
merged 1 commit into from
Mar 12, 2025
Merged

[move-vm] Representation of field borrow labels (#16102) #16106

merged 1 commit into from
Mar 12, 2025
+57 −21

Conversation

wrwg
Copy link
Contributor

@wrwg wrwg commented Mar 11, 2025

Description

Changes repr of labels for fields in the borrow graph to MemberCount. This fixes a bug in the borrow checker for variant fields.

Cherry picks #16102

How Has This Been Tested?

binary_sample test

@wrwg
[move-vm] Representation of field borrow labels (#16102)
a027298 
Changes repr of labels for fields in the borrow graph to `MemberCount`. This fixes a bug in the borrow checker for variant fields.
@wrwg wrwg requested review from georgemitenkov and sherry-x March 11, 2025 22:35
@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 11, 2025 •
edited
Loading

⏱️ 1h 53m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-unit-tests 31m 🟩 
rust-unit-tests 28m 🟩 
execution-performance / single-node-performance 25m 🟩 
rust-doc-tests 7m 🟩 
test-target-determinator 5m 🟩 
execution-performance / test-target-determinator 5m 🟩 
check-dynamic-deps 5m 🟩 🟩 
rust-cargo-deny 4m 🟩 🟩 
fetch-last-released-docker-image-tag 2m 🟩 
general-lints 56s 🟩 🟩 
semgrep/ci 46s 🟩 🟩 
file_change_determinator 20s 🟩 🟩 
file_change_determinator 9s 🟩 
permission-check 6s 🟩 🟩 
permission-check 5s 🟩 🟩 

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 25m 20m +25%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

georgemitenkov
georgemitenkov approved these changes Mar 11, 2025
View reviewed changes
aptos-move/e2e-benchmark/data/calibration_values.tsv
@@ -1,5 +1,5 @@
Loop { loop_count: Some(100000), loop_type: NoOp } 10 0.965 1.031 43125.6
Loop { loop_count: Some(10000), loop_type: Arithmetic } 10 0.986 1.080 26810.1
Loop { loop_count: Some(10000), loop_type: Arithmetic } 10 0.986 1.080 28685.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it ALWAYS hits me. @igor-aptos

@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 12, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@wrwg wrwg enabled auto-merge (squash) March 12, 2025 02:12
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on 6760e82ae3801836da0d39bcbeceb0ae31221072 ==> a02729845f9955cbe72c79c863b700fad9c6d605

Compatibility test results for 6760e82ae3801836da0d39bcbeceb0ae31221072 ==> a02729845f9955cbe72c79c863b700fad9c6d605 (PR)
1. Check liveness of validators at old version: 6760e82ae3801836da0d39bcbeceb0ae31221072
compatibility::simple-validator-upgrade::liveness-check : committed: 9886.79 txn/s, latency: 3483.00 ms, (p50: 2700 ms, p70: 2900, p90: 7800 ms, p99: 8700 ms), latency samples: 323640
2. Upgrading first Validator to new version: a02729845f9955cbe72c79c863b700fad9c6d605
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3435.80 txn/s, latency: 8673.91 ms, (p50: 9300 ms, p70: 10500, p90: 11200 ms, p99: 11400 ms), latency samples: 75620
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3415.56 txn/s, latency: 10096.50 ms, (p50: 11000 ms, p70: 11400, p90: 11600 ms, p99: 11700 ms), latency samples: 128600
3. Upgrading rest of first batch to new version: a02729845f9955cbe72c79c863b700fad9c6d605
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 2770.20 txn/s, latency: 10170.27 ms, (p50: 12100 ms, p70: 12600, p90: 12800 ms, p99: 12900 ms), latency samples: 51900
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3321.15 txn/s, latency: 10377.99 ms, (p50: 11300 ms, p70: 11900, p90: 11900 ms, p99: 12100 ms), latency samples: 127600
4. upgrading second batch to new version: a02729845f9955cbe72c79c863b700fad9c6d605
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 5966.68 txn/s, latency: 5103.96 ms, (p50: 5900 ms, p70: 6200, p90: 6400 ms, p99: 6700 ms), latency samples: 113620
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6038.32 txn/s, latency: 5654.41 ms, (p50: 6300 ms, p70: 6400, p90: 6600 ms, p99: 6700 ms), latency samples: 206120
5. check swarm health
Compatibility test for 6760e82ae3801836da0d39bcbeceb0ae31221072 ==> a02729845f9955cbe72c79c863b700fad9c6d605 passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a02729845f9955cbe72c79c863b700fad9c6d605

two traffics test: inner traffic : committed: 12984.60 txn/s, submitted: 12987.81 txn/s, expired: 3.21 txn/s, latency: 3046.82 ms, (p50: 2400 ms, p70: 2700, p90: 4600 ms, p99: 10300 ms), latency samples: 4937000
two traffics test : committed: 99.99 txn/s, latency: 3852.67 ms, (p50: 2300 ms, p70: 2800, p90: 9300 ms, p99: 15400 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 0.625, avg: 0.310", "ConsensusProposalToOrdered: max: 0.315, avg: 0.301", "ConsensusOrderedToCommit: max: 0.586, avg: 0.514", "ConsensusProposalToCommit: max: 0.896, avg: 0.815"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.92s no progress at version 30294 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.78s no progress at version 2523241 (avg 0.78s) [limit 16].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on 6760e82ae3801836da0d39bcbeceb0ae31221072 ==> a02729845f9955cbe72c79c863b700fad9c6d605

Compatibility test results for 6760e82ae3801836da0d39bcbeceb0ae31221072 ==> a02729845f9955cbe72c79c863b700fad9c6d605 (PR)
Upgrade the nodes to version: a02729845f9955cbe72c79c863b700fad9c6d605
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1657.53 txn/s, submitted: 1661.74 txn/s, failed submission: 4.21 txn/s, expired: 4.21 txn/s, latency: 1688.62 ms, (p50: 1500 ms, p70: 1800, p90: 2500 ms, p99: 5000 ms), latency samples: 149480
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1601.69 txn/s, submitted: 1606.13 txn/s, failed submission: 4.44 txn/s, expired: 4.44 txn/s, latency: 1800.55 ms, (p50: 1700 ms, p70: 2100, p90: 2700 ms, p99: 4000 ms), latency samples: 144320
5. check swarm health
Compatibility test for 6760e82ae3801836da0d39bcbeceb0ae31221072 ==> a02729845f9955cbe72c79c863b700fad9c6d605 passed
Upgrade the remaining nodes to version: a02729845f9955cbe72c79c863b700fad9c6d605
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 936.79 txn/s, submitted: 938.34 txn/s, failed submission: 1.55 txn/s, expired: 1.55 txn/s, latency: 3107.29 ms, (p50: 1800 ms, p70: 2300, p90: 11500 ms, p99: 13700 ms), latency samples: 84881
Test Ok

@wrwg wrwg merged commit 4ace64e into aptos-release-v1.27 Mar 12, 2025
87 of 90 checks passed
@wrwg wrwg deleted the wrwg/field_repr_1.27 branch March 12, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgao1996 vgao1996 vgao1996 approved these changes

@georgemitenkov georgemitenkov georgemitenkov approved these changes

@sherry-x sherry-x Awaiting requested review from sherry-x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wrwg @vgao1996 @georgemitenkov