Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gRPC] Implement Filter to Proto #16108

Merged
merged 4 commits into from
Mar 12, 2025
Merged

[gRPC] Implement Filter to Proto #16108

merged 4 commits into from
Mar 12, 2025

Conversation

just-in-chang
Copy link
Contributor

Description

Adds a to_proto function to the transaction filter. This makes defining the filter, both in configs and in code, a lot cleaner (look at the unit tests) when utilizing the filter protos in code.

How Has This Been Tested?

Unit tests.

Key Areas to Review

impl Into for the transaction filter structs.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Transaction Filter

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Mar 11, 2025

⏱️ 1h 18m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 25m 🟩
forge-compat-test / forge 13m 🟩
check-dynamic-deps 12m 🟩🟩🟩🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
rust-doc-tests 6m 🟩
execution-performance / test-target-determinator 5m 🟩
test-target-determinator 4m 🟩
general-lints 2m 🟩🟩🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 45s 🟩🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩
file_change_determinator 10s 🟩
permission-check 9s 🟩🟩🟩🟩
permission-check 3s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 6m 2m +150%
execution-performance / single-node-performance 25m 20m +27%

settingsfeedbackdocs ⋅ learn more about trunk.io

@just-in-chang just-in-chang enabled auto-merge (squash) March 12, 2025 22:17

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 206a8d450dd004f225d51c2c645163913bc5e7dd

two traffics test: inner traffic : committed: 12342.85 txn/s, submitted: 12353.95 txn/s, expired: 11.10 txn/s, latency: 3162.06 ms, (p50: 3000 ms, p70: 3200, p90: 4200 ms, p99: 7200 ms), latency samples: 4693000
two traffics test : committed: 99.99 txn/s, latency: 2450.86 ms, (p50: 1900 ms, p70: 2600, p90: 4100 ms, p99: 11100 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.480, avg: 0.990", "ConsensusProposalToOrdered: max: 0.308, avg: 0.303", "ConsensusOrderedToCommit: max: 0.650, avg: 0.494", "ConsensusProposalToCommit: max: 0.958, avg: 0.797"]
Max non-epoch-change gap was: 1 rounds at version 2450260 (avg 0.00) [limit 4], 1.81s no progress at version 2450260 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.96s no progress at version 2430028 (avg 0.96s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 206a8d450dd004f225d51c2c645163913bc5e7dd

Compatibility test results for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 206a8d450dd004f225d51c2c645163913bc5e7dd (PR)
Upgrade the nodes to version: 206a8d450dd004f225d51c2c645163913bc5e7dd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 997.04 txn/s, submitted: 1000.37 txn/s, failed submission: 3.33 txn/s, expired: 3.33 txn/s, latency: 3125.61 ms, (p50: 2000 ms, p70: 3900, p90: 6600 ms, p99: 8400 ms), latency samples: 89920
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1102.52 txn/s, submitted: 1106.47 txn/s, failed submission: 3.95 txn/s, expired: 3.95 txn/s, latency: 2808.88 ms, (p50: 1900 ms, p70: 3300, p90: 5100 ms, p99: 8300 ms), latency samples: 94842
5. check swarm health
Compatibility test for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 206a8d450dd004f225d51c2c645163913bc5e7dd passed
Upgrade the remaining nodes to version: 206a8d450dd004f225d51c2c645163913bc5e7dd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1231.89 txn/s, submitted: 1234.80 txn/s, failed submission: 2.91 txn/s, expired: 2.91 txn/s, latency: 2373.52 ms, (p50: 2000 ms, p70: 2400, p90: 3800 ms, p99: 8100 ms), latency samples: 110080
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 206a8d450dd004f225d51c2c645163913bc5e7dd

Compatibility test results for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 206a8d450dd004f225d51c2c645163913bc5e7dd (PR)
1. Check liveness of validators at old version: c5eef1450476a6f7eee96d0d1953b65df04fdb91
compatibility::simple-validator-upgrade::liveness-check : committed: 11695.74 txn/s, latency: 2774.77 ms, (p50: 2800 ms, p70: 3000, p90: 3200 ms, p99: 4300 ms), latency samples: 396340
2. Upgrading first Validator to new version: 206a8d450dd004f225d51c2c645163913bc5e7dd
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 1221.08 txn/s, latency: 17684.60 ms, (p50: 19400 ms, p70: 23000, p90: 26000 ms, p99: 26800 ms), latency samples: 49720
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1396.65 txn/s, latency: 17487.00 ms, (p50: 20800 ms, p70: 22000, p90: 23300 ms, p99: 24600 ms), latency samples: 76780
3. Upgrading rest of first batch to new version: 206a8d450dd004f225d51c2c645163913bc5e7dd
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 2681.03 txn/s, latency: 10351.68 ms, (p50: 11100 ms, p70: 12300, p90: 12800 ms, p99: 13800 ms), latency samples: 65380
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 941.21 txn/s, latency: 27268.24 ms, (p50: 30200 ms, p70: 34900, p90: 37900 ms, p99: 39000 ms), latency samples: 49640
4. upgrading second batch to new version: 206a8d450dd004f225d51c2c645163913bc5e7dd
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 2918.86 txn/s, latency: 10500.60 ms, (p50: 12400 ms, p70: 13900, p90: 14100 ms, p99: 14300 ms), latency samples: 58040
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5422.52 txn/s, latency: 6335.14 ms, (p50: 7000 ms, p70: 7200, p90: 7400 ms, p99: 7600 ms), latency samples: 186180
5. check swarm health
Compatibility test for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 206a8d450dd004f225d51c2c645163913bc5e7dd passed
Test Ok

@just-in-chang just-in-chang merged commit c911bca into main Mar 12, 2025
88 checks passed
@just-in-chang just-in-chang deleted the justin/filter-to-proto branch March 12, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants