Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] remove old config and Payload variants #16118

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bchocho
Copy link
Contributor

@bchocho bchocho commented Mar 12, 2025

Description

Removes config allow_batches_without_pos_in_proposal and keep the logic for when this was true.
Removes the Payload variants InQuorumStore and InQuorumStoreWithLimits that were (a) not in the logic for true above and (b) not being used in production.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Mar 12, 2025

⏱️ 1h 37m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 47m 🟩🟩
test-target-determinator 11m 🟩🟩
execution-performance / test-target-determinator 10m 🟩🟩
check-dynamic-deps 7m 🟩🟩🟩
rust-doc-tests 6m 🟩
rust-doc-tests 5m 🟥
rust-cargo-deny 4m 🟩🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
general-lints 1m 🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 32s 🟩🟩🟩
file_change_determinator 21s 🟩🟩
permission-check 7s 🟩🟩
permission-check 7s 🟩🟩🟩
permission-check 6s 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
test-target-determinator 6m 5m +34%

settingsfeedbackdocs ⋅ learn more about trunk.io

@bchocho bchocho added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Mar 12, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@bchocho bchocho force-pushed the brian/remove-old-payload-variants branch from 7988453 to 7db870f Compare March 12, 2025 22:35

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 7db870f1680959860fdc6afc17fdbfbe1ec1b4c7

two traffics test: inner traffic : committed: 11908.40 txn/s, submitted: 11910.46 txn/s, expired: 2.05 txn/s, latency: 3321.90 ms, (p50: 3300 ms, p70: 3600, p90: 4500 ms, p99: 6300 ms), latency samples: 4527840
two traffics test : committed: 99.97 txn/s, latency: 2412.84 ms, (p50: 1800 ms, p70: 2700, p90: 4200 ms, p99: 6200 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.379, avg: 0.833", "ConsensusProposalToOrdered: max: 0.320, avg: 0.314", "ConsensusOrderedToCommit: max: 0.480, avg: 0.426", "ConsensusProposalToCommit: max: 0.795, avg: 0.740"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.12s no progress at version 20589 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.64s no progress at version 2044480 (avg 0.64s) [limit 16].
Test Ok

Copy link
Contributor

❌ Forge suite compat failure on c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> 7db870f1680959860fdc6afc17fdbfbe1ec1b4c7

Forge test runner terminated:
Trailing Log Lines:
{"level":"INFO","source":{"package":"aptos_testcases","file":"testsuite/testcases/src/lib.rs:102"},"thread_name":"emitter-47","hostname":"forge-compat-pr-16118-1741819825-c5eef1450476a6f7eee96d0d1953b6","timestamp":"2025-03-12T22:54:00.742464Z","message":"batch_update_gradually upgrade waiting: 0x85fa92ce810796b6760e6a7f6f3fff4270a156a6a87ac75887ecf465f518cdd6"}
{"level":"INFO","source":{"package":"aptos_testcases","file":"testsuite/testcases/src/lib.rs:114"},"thread_name":"emitter-50","hostname":"forge-compat-pr-16118-1741819825-c5eef1450476a6f7eee96d0d1953b6","timestamp":"2025-03-12T22:54:00.771332Z","message":"batch_update_gradually upgrade healthy: 0x85fa92ce810796b6760e6a7f6f3fff4270a156a6a87ac75887ecf465f518cdd6"}
{"level":"INFO","source":{"package":"aptos_testcases","file":"testsuite/testcases/src/lib.rs:117"},"thread_name":"emitter-50","hostname":"forge-compat-pr-16118-1741819825-c5eef1450476a6f7eee96d0d1953b6","timestamp":"2025-03-12T22:54:00.771350Z","message":"batch_update_gradually upgrade delay: 10s"}
{"level":"INFO","source":{"package":"aptos_testcases","file":"testsuite/testcases/src/lib.rs:120"},"thread_name":"emitter-40","hostname":"forge-compat-pr-16118-1741819825-c5eef1450476a6f7eee96d0d1953b6","timestamp":"2025-03-12T22:54:10.773008Z","message":"batch_update_gradually upgrade done: 0x85fa92ce810796b6760e6a7f6f3fff4270a156a6a87ac75887ecf465f518cdd6"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/swarm.rs:686"},"thread_name":"emitter-40","hostname":"forge-compat-pr-16118-1741819825-c5eef1450476a6f7eee96d0d1953b6","timestamp":"2025-03-12T22:54:10.799748Z","message":"Node validator-1 healthy @ version 399428 > 100"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/swarm.rs:686"},"thread_name":"emitter-47","hostname":"forge-compat-pr-16118-1741819825-c5eef1450476a6f7eee96d0d1953b6","timestamp":"2025-03-12T22:54:10.829871Z","message":"Node validator-3 healthy @ version 399428 > 100"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/swarm.rs:686"},"thread_name":"emitter-10","hostname":"forge-compat-pr-16118-1741819825-c5eef1450476a6f7eee96d0d1953b6","timestamp":"2025-03-12T22:54:10.857367Z","message":"Node validator-0 healthy @ version 399428 > 100"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/swarm.rs:686"},"thread_name":"emitter-40","hostname":"forge-compat-pr-16118-1741819825-c5eef1450476a6f7eee96d0d1953b6","timestamp":"2025-03-12T22:54:10.888488Z","message":"Node validator-2 healthy @ version 399428 > 100"}
{"level":"INFO","source":{"package":"aptos_testcases","file":"testsuite/testcases/src/compatibility_test.rs:127"},"thread_name":"emitter-40","hostname":"forge-compat-pr-16118-1741819825-c5eef1450476a6f7eee96d0d1953b6","timestamp":"2025-03-12T22:54:10.889206Z","message":"upgrade_and_gather_stats upgrade thread 1"}
{"level":"INFO","source":{"package":"aptos_testcases","file":"testsuite/testcases/src/compatibility_test.rs:129"},"thread_name":"emitter-40","hostname":"forge-compat-pr-16118-1741819825-c5eef1450476a6f7eee96d0d1953b6","timestamp":"2025-03-12T22:54:10.889218Z","message":"upgrade_and_gather_stats upgrade thread done"}
Debugging output:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant