Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[index] support all statement #5060

Merged
merged 1 commit into from
Dec 18, 2022
Merged

[index] support all statement #5060

merged 1 commit into from
Dec 18, 2022

Conversation

s7v7nislands
Copy link
Contributor

@s7v7nislands s7v7nislands commented Oct 15, 2022

Description

support all statement

Test Plan


This change is Reviewable

@bowenyang007
Copy link
Contributor

Sorry didn't see this earlier. Curious why we want to support all statements? Is there a use case for supporting more than insert?

@s7v7nislands
Copy link
Contributor Author

we need update statements in some cases in our product. and I think it may be beneficial for common use.

@bowenyang007
Copy link
Contributor

Sorry for the late stamp. I missed the response. Thanks for generalizing the API!

@davidiw davidiw enabled auto-merge (squash) December 3, 2022 22:37
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@gregnazario
Copy link
Contributor

I restarted the compatibility test, looks like a transient test harness issue

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 69094d9d3cdc62e54754a32fad1e73f0fc129103

performance benchmark with full nodes : 6352 TPS, 6254 ms latency, 9000 ms p99 latency,(!) expired 240 out of 2712940 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 69094d9d3cdc62e54754a32fad1e73f0fc129103

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 69094d9d3cdc62e54754a32fad1e73f0fc129103 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7334 TPS, 5283 ms latency, 8300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 69094d9d3cdc62e54754a32fad1e73f0fc129103
compatibility::simple-validator-upgrade::single-validator-upgrade : 4673 TPS, 8748 ms latency, 11500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 69094d9d3cdc62e54754a32fad1e73f0fc129103
compatibility::simple-validator-upgrade::half-validator-upgrade : 4738 TPS, 8552 ms latency, 11700 ms p99 latency,no expired txns
4. upgrading second batch to new version: 69094d9d3cdc62e54754a32fad1e73f0fc129103
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6696 TPS, 5851 ms latency, 10900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 69094d9d3cdc62e54754a32fad1e73f0fc129103 passed
Test Ok

@davidiw davidiw merged commit 6d4d858 into aptos-labs:main Dec 18, 2022
@Markuze Markuze mentioned this pull request Dec 26, 2022
@s7v7nislands s7v7nislands deleted the refactor_error branch January 6, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants