Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and edit Your First Dapp tutorial #5106

Merged
merged 7 commits into from
Dec 3, 2022
Merged

Test and edit Your First Dapp tutorial #5106

merged 7 commits into from
Dec 3, 2022

Conversation

clay-aptos
Copy link
Contributor

@clay-aptos clay-aptos commented Oct 17, 2022 •
edited
Loading

Description

Walked through the tutorial line by line
Ran the example and updated output to match
Edited the text throughout

Test Plan

Edit ans test doc in browser

This change is Reviewable

@clay-aptos clay-aptos requested a review from areshand as a code owner October 17, 2022 23:18
@clay-aptos clay-aptos marked this pull request as draft October 17, 2022 23:18
@clay-aptos clay-aptos changed the title Update first-dapp.md Test and edit Your First Dapp tutorial #5162 Oct 24, 2022
@clay-aptos clay-aptos changed the title Test and edit Your First Dapp tutorial #5162 Test and edit Your First Dapp tutorial Oct 24, 2022
@clay-aptos clay-aptos mentioned this pull request Nov 3, 2022
Closed
@davidiw davidiw marked this pull request as ready for review November 5, 2022 20:17
@davidiw
Copy link
Contributor

davidiw commented Nov 5, 2022

shall we wrap this one up?

@clay-aptos
Copy link
Contributor Author

shall we wrap this one up?

Makes sense to me. All of these tutorials should be revisited. Please approve when you are ready. Thanks!

@clay-aptos clay-aptos enabled auto-merge (squash) November 7, 2022 16:27
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> fa9429ff8dedf2c3cad4c87c2427c20637e92907

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> fa9429ff8dedf2c3cad4c87c2427c20637e92907 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7356 TPS, 5217 ms latency, 7800 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: fa9429ff8dedf2c3cad4c87c2427c20637e92907
compatibility::simple-validator-upgrade::single-validator-upgrade : 4538 TPS, 9152 ms latency, 11600 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: fa9429ff8dedf2c3cad4c87c2427c20637e92907
compatibility::simple-validator-upgrade::half-validator-upgrade : 4559 TPS, 8808 ms latency, 12200 ms p99 latency,no expired txns
4. upgrading second batch to new version: fa9429ff8dedf2c3cad4c87c2427c20637e92907
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6684 TPS, 5715 ms latency, 10300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> fa9429ff8dedf2c3cad4c87c2427c20637e92907 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

✅ Forge suite land_blocking success on fa9429ff8dedf2c3cad4c87c2427c20637e92907

performance benchmark with full nodes : 6734 TPS, 5913 ms latency, 17400 ms p99 latency,(!) expired 200 out of 2875660 txns
Test Ok

@clay-aptos clay-aptos marked this pull request as draft November 9, 2022 17:19
auto-merge was automatically disabled November 9, 2022 17:19

Pull request was converted to draft

@davidiw
Copy link
Contributor

davidiw commented Dec 3, 2022

Haha, you left this as draft

@davidiw davidiw marked this pull request as ready for review December 3, 2022 21:01
@davidiw davidiw merged commit 391a1a6 into main Dec 3, 2022
@davidiw davidiw deleted the clay-aptos-patch-7 branch December 3, 2022 21:01
@clay-aptos
Copy link
Contributor Author

Haha, you left this as draft

Only because I wasn't done. :-)

@Markuze Markuze mentioned this pull request Dec 5, 2022
Closed
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@clay-aptos @areshand
Test and edit Your First Dapp tutorial (aptos-labs#5106)
36704fb 
* Update first-dapp.md

* Test and edit Your First Dapp tutorial

* Update first-dapp.md

* Update first-dapp.md

* Update first-dapp.md

* Update first-dapp.md
@Markuze Markuze mentioned this pull request Dec 26, 2022
Closed
@Markuze Markuze mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidiw davidiw davidiw approved these changes

@areshand areshand Awaiting requested review from areshand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clay-aptos @davidiw