Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS SDK ] bump version to 1.4.0 #5736

Merged
merged 3 commits into from
Nov 30, 2022
Merged

[TS SDK ] bump version to 1.4.0 #5736

merged 3 commits into from
Nov 30, 2022

Conversation

0xmaayan
Copy link
Contributor

Description

bump TS SDK version from 1.3.18 to 1.4.0

banool
banool approved these changes Nov 30, 2022
View reviewed changes
ecosystem/typescript/sdk/CHANGELOG.md
@@ -6,6 +6,9 @@ All notable changes to the Aptos Node SDK will be captured in this file. This ch

## Unreleased

N/A
Copy link
Contributor

@banool banool Nov 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit: add a newline after this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit picking. lol

@banool banool enabled auto-merge (squash) November 30, 2022 19:13
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d456acadc5cf86494754ba08ba7f98403367b9e7

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d456acadc5cf86494754ba08ba7f98403367b9e7 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7030 TPS, 5500 ms latency, 7800 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: d456acadc5cf86494754ba08ba7f98403367b9e7
compatibility::simple-validator-upgrade::single-validator-upgrade : 4901 TPS, 8441 ms latency, 11500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: d456acadc5cf86494754ba08ba7f98403367b9e7
compatibility::simple-validator-upgrade::half-validator-upgrade : 4893 TPS, 8449 ms latency, 11400 ms p99 latency,no expired txns
4. upgrading second batch to new version: d456acadc5cf86494754ba08ba7f98403367b9e7
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6872 TPS, 5717 ms latency, 9400 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d456acadc5cf86494754ba08ba7f98403367b9e7 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on d456acadc5cf86494754ba08ba7f98403367b9e7

performance benchmark with full nodes : 6753 TPS, 5850 ms latency, 10800 ms p99 latency,(!) expired 1360 out of 2885060 txns
Test Ok

@banool banool merged commit ac08df6 into main Nov 30, 2022
@banool banool deleted the bump_ts_sdk_version branch November 30, 2022 19:37
@Markuze Markuze mentioned this pull request Dec 5, 2022
Closed
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@0xmaayan @areshand
[TS SDK ] bump version to 1.4.0 (aptos-labs#5736)
339eac9 
* [TS SDK] bump version to 1.4.0

* [TS SDK] bump version to 1.4.0

* lint
@Markuze Markuze mentioned this pull request Dec 26, 2022
Closed
@Markuze Markuze mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjleng jjleng jjleng approved these changes

@gregnazario gregnazario gregnazario approved these changes

@banool banool banool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xmaayan @jjleng @gregnazario @banool