[docs] updated governance doc #5778

0xchloe · 2022-12-06T01:05:50Z

Description

Added more details to the governance doc. Lmk if I'm missing anything, would be happy to add more : )

Test Plan

clay-aptos · 2022-12-06T22:57:41Z

And when this lands, I will update See what's new to summarize it:
https://aptos.dev/whats-new-in-docs

Thanks, @0xchloe !

movekevin · 2022-12-07T06:57:33Z

developer-docs-site/docs/concepts/governance.md

@@ -33,9 +33,9 @@ sources={{

 ## Who can propose

- To either propose or vote, you must stake but you are not required to run a validator node. However, we recommend that you be a validator with a stake and be a part of the validator set. 
+- To either propose or vote, you must stake, but you are not required to run a validator node. However, we recommend that you be a validator with a stake and be a part of the validator set. 


nit: Rationale for why becoming a validator is recommended is that users will also gain rewards.

movekevin · 2022-12-07T06:58:07Z

developer-docs-site/docs/concepts/governance.md

+
+## Aptos Improvement Proposals (AIPs)
+
+AIPs are proposals created by the Aptos community or the Aptos Labs team to improve the operations and development of the Aptos chain. 


I would omit "the Aptos Labs team"

movekevin · 2022-12-07T06:58:45Z

developer-docs-site/docs/concepts/governance.md

+## Aptos Improvement Proposals (AIPs)
+
+AIPs are proposals created by the Aptos community or the Aptos Labs team to improve the operations and development of the Aptos chain. 
+To submit an AIP, create an issue in [`Aptos Foundation's github repository`](https://github.com/aptos-foundation/AIPs/issues). 


Can we add a callout that they should also follow the template there?

movekevin · 2022-12-07T06:59:39Z

developer-docs-site/docs/concepts/governance.md

+The `aptos_governance` module outlines how users can interact with Aptos Governance. It's the external-facing module of the Aptos on-chain governance process and contains logic and checks that are specific to Aptos Governance.
+The `voting` module is the Aptos governance standard that can be used by DAOs on the Aptos chain to create their own on-chain governance process.
+
+If you are thinking about creating a DAO on Aptos, you can refer to `aptos_governance`'s usage of the `voting` module as an example. 


Can you add more details on the functionalities of the voting module and may be just simple explanation of how a DAO can leverage them? We'll add a more detailed tutorial soon.

developer-docs-site/docs/concepts/governance.md

davidiw · 2022-12-11T03:28:23Z

developer-docs-site/docs/concepts/governance.md

+
+## Aptos Improvement Proposals (AIPs)
+
+AIPs are proposals created by the Aptos community or the Aptos Labs team to improve the operations and development of the Aptos chain. 


Suggested change

AIPs are proposals created by the Aptos community or the Aptos Labs team to improve the operations and development of the Aptos chain.

AIPs are proposals created by the Aptos community to improve the operations and development of the Aptos blockchain.

developer-docs-site/docs/concepts/governance.md

github-actions · 2022-12-11T18:06:43Z

✅ Forge suite `land_blocking` success on `56fd8c979a4b61bad73320f1dce8b162acfb1147`

performance benchmark with full nodes : 6549 TPS, 6062 ms latency, 12700 ms p99 latency,(!) expired 280 out of 2796960 txns
Test Ok

Grafana dashboard
Humio Logs
Test runner output
Test run is land-blocking

github-actions · 2022-12-11T18:11:42Z

✅ Forge suite `compat` success on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `56fd8c979a4b61bad73320f1dce8b162acfb1147`

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 56fd8c979a4b61bad73320f1dce8b162acfb1147 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7144 TPS, 5569 ms latency, 8500 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 56fd8c979a4b61bad73320f1dce8b162acfb1147
compatibility::simple-validator-upgrade::single-validator-upgrade : 4831 TPS, 8433 ms latency, 11100 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 56fd8c979a4b61bad73320f1dce8b162acfb1147
compatibility::simple-validator-upgrade::half-validator-upgrade : 4978 TPS, 8135 ms latency, 10300 ms p99 latency,no expired txns
4. upgrading second batch to new version: 56fd8c979a4b61bad73320f1dce8b162acfb1147
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6631 TPS, 5848 ms latency, 9600 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 56fd8c979a4b61bad73320f1dce8b162acfb1147 passed
Test Ok

Grafana dashboard
Humio Logs
Test runner output
Test run is land-blocking

davidiw · 2022-12-11T18:13:31Z

And when this lands, I will update See what's new to summarize it: https://aptos.dev/whats-new-in-docs

Thanks, @0xchloe !

@clay-aptos it landed

clay-aptos · 2022-12-12T17:25:02Z

And when this lands, I will update See what's new to summarize it: https://aptos.dev/whats-new-in-docs
Thanks, @0xchloe !

@clay-aptos it landed

Thanks! Announcement PR here:
#5862

Also see a lingering question on an accompanying code comment I have above. Thanks again.

* rebased * Update developer-docs-site/docs/concepts/governance.md * Update developer-docs-site/docs/concepts/governance.md * Update developer-docs-site/docs/concepts/governance.md * Update developer-docs-site/docs/concepts/governance.md * Update developer-docs-site/docs/concepts/governance.md * Update developer-docs-site/docs/concepts/governance.md Co-authored-by: chloeqjz <[email protected]> Co-authored-by: David Wolinsky <[email protected]>

0xchloe requested review from davidiw and clay-aptos as code owners December 6, 2022 01:05

0xchloe requested a review from movekevin December 6, 2022 01:05

0xchloe force-pushed the governance_docs branch 2 times, most recently from c8f59ae to 657fe76 Compare December 7, 2022 03:45

rebased

8aea05a

0xchloe force-pushed the governance_docs branch from 657fe76 to 8aea05a Compare December 7, 2022 03:46

movekevin reviewed Dec 7, 2022

View reviewed changes

davidiw approved these changes Dec 11, 2022

View reviewed changes

davidiw added 5 commits December 10, 2022 19:31

Update developer-docs-site/docs/concepts/governance.md

5665d2d

Update developer-docs-site/docs/concepts/governance.md

5391b16

Update developer-docs-site/docs/concepts/governance.md

7dd25d7

Update developer-docs-site/docs/concepts/governance.md

fc7c2ff

Update developer-docs-site/docs/concepts/governance.md

860289d

davidiw enabled auto-merge (squash) December 11, 2022 03:31

This comment has been minimized.

Sign in to view

davidiw approved these changes Dec 11, 2022

View reviewed changes

developer-docs-site/docs/concepts/governance.md Outdated Show resolved Hide resolved

Update developer-docs-site/docs/concepts/governance.md

56fd8c9

This comment has been minimized.

Sign in to view

davidiw disabled auto-merge December 11, 2022 18:13

davidiw merged commit 7c09e05 into main Dec 11, 2022

davidiw deleted the governance_docs branch December 11, 2022 18:13

Markuze mentioned this pull request Dec 26, 2022

markuze/aptos perf #5998

Closed

Markuze mentioned this pull request Jan 3, 2023

[Network] Adding AptosPerf Client #6054

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docs] updated governance doc #5778

[docs] updated governance doc #5778

0xchloe commented Dec 6, 2022 •

edited

Loading

clay-aptos commented Dec 6, 2022

movekevin Dec 7, 2022

movekevin Dec 7, 2022

movekevin Dec 7, 2022

movekevin Dec 7, 2022

davidiw Dec 11, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 11, 2022

github-actions bot commented Dec 11, 2022

davidiw commented Dec 11, 2022

clay-aptos commented Dec 12, 2022


		## Aptos Improvement Proposals (AIPs)

		AIPs are proposals created by the Aptos community or the Aptos Labs team to improve the operations and development of the Aptos chain.

[docs] updated governance doc #5778

[docs] updated governance doc #5778

Conversation

0xchloe commented Dec 6, 2022 • edited Loading

Description

Test Plan

clay-aptos commented Dec 6, 2022

movekevin Dec 7, 2022

Choose a reason for hiding this comment

movekevin Dec 7, 2022

Choose a reason for hiding this comment

movekevin Dec 7, 2022

Choose a reason for hiding this comment

movekevin Dec 7, 2022

Choose a reason for hiding this comment

davidiw Dec 11, 2022

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 11, 2022

✅ Forge suite land_blocking success on 56fd8c979a4b61bad73320f1dce8b162acfb1147

github-actions bot commented Dec 11, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 56fd8c979a4b61bad73320f1dce8b162acfb1147

davidiw commented Dec 11, 2022

clay-aptos commented Dec 12, 2022

0xchloe commented Dec 6, 2022 •

edited

Loading

✅ Forge suite `land_blocking` success on `56fd8c979a4b61bad73320f1dce8b162acfb1147`

✅ Forge suite `compat` success on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `56fd8c979a4b61bad73320f1dce8b162acfb1147`