Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[replay-verify] Add an option to re-validate all move modules in the snapshot #5793

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

runtian-zhou
Copy link
Contributor

Description

Add a validate-modules flag to the replay-verify tool to scan over all the published move modules and run it with the lastest move bytecode verifier.

Test Plan

Ran it with the latest snapshots and confirmed the modules are reported correctly.

@runtian-zhou
Copy link
Contributor Author

The next step is to set up a triggerable CI job for this command so that we can use it for hotfix.

Copy link
Contributor

@msmouse msmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be tricky to understand how to use (pass in a relatively new --start-version so the latest snapshot will be checked), but looks like works for your purpose

@runtian-zhou runtian-zhou force-pushed the runtianz/validate_modules branch from 706c993 to 000969b Compare December 7, 2022 21:42
@runtian-zhou runtian-zhou requested a review from grao1991 December 7, 2022 22:00
@runtian-zhou runtian-zhou enabled auto-merge (squash) December 7, 2022 22:11
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

✅ Forge suite land_blocking success on 000969b2e30edd4b97736a53edec5903ccb45204

performance benchmark with full nodes : 6881 TPS, 5771 ms latency, 8100 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 000969b2e30edd4b97736a53edec5903ccb45204

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 000969b2e30edd4b97736a53edec5903ccb45204 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7386 TPS, 5258 ms latency, 6700 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 000969b2e30edd4b97736a53edec5903ccb45204
compatibility::simple-validator-upgrade::single-validator-upgrade : 4895 TPS, 8319 ms latency, 10500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 000969b2e30edd4b97736a53edec5903ccb45204
compatibility::simple-validator-upgrade::half-validator-upgrade : 4418 TPS, 9291 ms latency, 12300 ms p99 latency,no expired txns
4. upgrading second batch to new version: 000969b2e30edd4b97736a53edec5903ccb45204
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6794 TPS, 5692 ms latency, 10200 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 000969b2e30edd4b97736a53edec5903ccb45204 passed
Test Ok

@runtian-zhou runtian-zhou merged commit a5641a4 into main Dec 7, 2022
@runtian-zhou runtian-zhou deleted the runtianz/validate_modules branch December 7, 2022 22:54
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@Markuze Markuze mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants