Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct database versioning classification #5840

Merged
merged 2 commits into from
Dec 11, 2022
Merged

Correct database versioning classification #5840

merged 2 commits into from
Dec 11, 2022

Conversation

alnoki
Copy link
Contributor

@alnoki alnoki commented Dec 9, 2022

msmouse
msmouse reviewed Dec 9, 2022
View reviewed changes
developer-docs-site/docs/concepts/txns-states.md Outdated
@@ -90,7 +90,7 @@ Anyone can submit a transaction to the Aptos blockchain to modify the ledger sta

The Aptos blockchain uses proof to verify the authenticity and correctness of the blockchain data.

All data in the Aptos blockchain is stored in a single-version distributed database. Each validator and fullnode's [storage](./validator-nodes#storage) is responsible for persisting the agreed upon blocks of transactions and their execution results to the database.
All data in the Aptos blockchain is stored in a multi-version distributed database. Each validator and fullnode's [storage](./validator-nodes#storage) is responsible for persisting the agreed upon blocks of transactions and their execution results to the database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either "single-version" or "multi-version" is confusing in this context. Let's say something along the line of "the same Aptos blockchain data is replicated across the network, to every Aptos node", for example? Some English speaker please advice :trollface: .

@davidiw davidiw enabled auto-merge (squash) December 11, 2022 05:10
@davidiw davidiw disabled auto-merge December 11, 2022 05:10
@davidiw davidiw merged commit 1eee052 into aptos-labs:main Dec 11, 2022
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on d6e90e438f601fccace398bf1ffd2433633f243c

performance benchmark with full nodes : 6388 TPS, 6212 ms latency, 11100 ms p99 latency,(!) expired 160 out of 2727860 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d6e90e438f601fccace398bf1ffd2433633f243c

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d6e90e438f601fccace398bf1ffd2433633f243c (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7091 TPS, 5410 ms latency, 8500 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: d6e90e438f601fccace398bf1ffd2433633f243c
compatibility::simple-validator-upgrade::single-validator-upgrade : 4648 TPS, 8435 ms latency, 11800 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: d6e90e438f601fccace398bf1ffd2433633f243c
compatibility::simple-validator-upgrade::half-validator-upgrade : 4561 TPS, 9118 ms latency, 11300 ms p99 latency,no expired txns
4. upgrading second batch to new version: d6e90e438f601fccace398bf1ffd2433633f243c
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6350 TPS, 6153 ms latency, 9800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d6e90e438f601fccace398bf1ffd2433633f243c passed
Test Ok

areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@alnoki @davidiw @areshand
Correct database versioning classification (aptos-labs#5840)
17b387b 
* Correct database versioning classification

* Update developer-docs-site/docs/concepts/txns-states.md

Co-authored-by: David Wolinsky <[email protected]>
@Markuze Markuze mentioned this pull request Dec 26, 2022
Closed
@Markuze Markuze mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidiw davidiw davidiw left review comments

@msmouse msmouse msmouse left review comments

@clay-aptos clay-aptos Awaiting requested review from clay-aptos

@movekevin movekevin Awaiting requested review from movekevin

@lightmark lightmark Awaiting requested review from lightmark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alnoki @davidiw @msmouse