Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move-vm] Generalize metadata for attribute parameters #5896

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

wrwg
Copy link
Contributor

@wrwg wrwg commented Dec 16, 2022

This generalizes metadata stored in the bytecode for attributes to allow parameters, as in #[storage_group(group)]. This was added recently for #[view] but did not support parameters. Folding this into current release will avoid breaking changes later.

@wrwg wrwg requested review from davidiw, msmouse and zekun000 December 16, 2022 16:29
@wrwg wrwg requested a review from movekevin as a code owner December 16, 2022 16:29
@wrwg wrwg added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Dec 16, 2022
@wrwg wrwg enabled auto-merge (squash) December 16, 2022 16:29
This generalizes metadata stored in the bytecode for attributes to allow parameters, as in `#[storage_group(group)]`. This was added recently for `#[view]` but did not support parameters. Folding this into current release will avoid breaking changes later.
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 79a15ed62e76c2e1749ce2f63bfcf23126d7f0b1

performance benchmark with full nodes : 5984 TPS, 6642 ms latency, 12100 ms p99 latency,(!) expired 500 out of 2555700 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 79a15ed62e76c2e1749ce2f63bfcf23126d7f0b1

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 79a15ed62e76c2e1749ce2f63bfcf23126d7f0b1 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7416 TPS, 5386 ms latency, 8300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 79a15ed62e76c2e1749ce2f63bfcf23126d7f0b1
compatibility::simple-validator-upgrade::single-validator-upgrade : 4407 TPS, 9475 ms latency, 12200 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 79a15ed62e76c2e1749ce2f63bfcf23126d7f0b1
compatibility::simple-validator-upgrade::half-validator-upgrade : 4461 TPS, 9223 ms latency, 12000 ms p99 latency,no expired txns
4. upgrading second batch to new version: 79a15ed62e76c2e1749ce2f63bfcf23126d7f0b1
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6276 TPS, 6056 ms latency, 11300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 79a15ed62e76c2e1749ce2f63bfcf23126d7f0b1 passed
Test Ok

@wrwg wrwg disabled auto-merge December 16, 2022 20:16
@wrwg wrwg merged commit abf10b4 into aptos-labs:main Dec 17, 2022
wrwg added a commit to wrwg/aptos-core that referenced this pull request Dec 18, 2022
…ptos-labs#5896)

This generalizes metadata stored in the bytecode for attributes to allow parameters, as in `#[storage_group(group)]`. This was added recently for `#[view]` but did not support parameters. Folding this into current release will avoid breaking changes later.
wrwg added a commit that referenced this pull request Dec 19, 2022
…5896) (#5916)

This generalizes metadata stored in the bytecode for attributes to allow parameters, as in `#[storage_group(group)]`. This was added recently for `#[view]` but did not support parameters. Folding this into current release will avoid breaking changes later.
@Markuze Markuze mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants