-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move-vm] Generalize metadata for attribute parameters #5896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This generalizes metadata stored in the bytecode for attributes to allow parameters, as in `#[storage_group(group)]`. This was added recently for `#[view]` but did not support parameters. Folding this into current release will avoid breaking changes later.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
runtian-zhou
approved these changes
Dec 16, 2022
✅ Forge suite
|
vgao1996
approved these changes
Dec 16, 2022
movekevin
approved these changes
Dec 17, 2022
wrwg
added a commit
to wrwg/aptos-core
that referenced
this pull request
Dec 18, 2022
…ptos-labs#5896) This generalizes metadata stored in the bytecode for attributes to allow parameters, as in `#[storage_group(group)]`. This was added recently for `#[view]` but did not support parameters. Folding this into current release will avoid breaking changes later.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes metadata stored in the bytecode for attributes to allow parameters, as in
#[storage_group(group)]
. This was added recently for#[view]
but did not support parameters. Folding this into current release will avoid breaking changes later.