Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parallel Execution] Counter for dependency waits #5915

Merged
merged 1 commit into from
Dec 17, 2022
Merged

[Parallel Execution] Counter for dependency waits #5915

merged 1 commit into from
Dec 17, 2022

Conversation

gelash
Copy link
Contributor

@gelash gelash commented Dec 17, 2022

Add a counter for monitoring, e.g. with more threads should observe more aborts and dependency waits, and actually dependency waits are saving aborts, so good complementary metric to the number of speculative aborts.

@gelash gelash added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Dec 17, 2022
@gelash gelash marked this pull request as ready for review December 17, 2022 21:01
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 9a43a61221804576c13fb5eb9a651e3ec21d080a

performance benchmark with full nodes : 6127 TPS, 6483 ms latency, 13500 ms p99 latency,(!) expired 280 out of 2616700 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9a43a61221804576c13fb5eb9a651e3ec21d080a

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9a43a61221804576c13fb5eb9a651e3ec21d080a (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7140 TPS, 5427 ms latency, 8300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 9a43a61221804576c13fb5eb9a651e3ec21d080a
compatibility::simple-validator-upgrade::single-validator-upgrade : 4720 TPS, 8715 ms latency, 11500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 9a43a61221804576c13fb5eb9a651e3ec21d080a
compatibility::simple-validator-upgrade::half-validator-upgrade : 4722 TPS, 8823 ms latency, 12000 ms p99 latency,no expired txns
4. upgrading second batch to new version: 9a43a61221804576c13fb5eb9a651e3ec21d080a
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6609 TPS, 5920 ms latency, 10900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9a43a61221804576c13fb5eb9a651e3ec21d080a passed
Test Ok

@gelash gelash merged commit c8cca1c into main Dec 17, 2022
@gelash gelash deleted the waitcnt branch December 17, 2022 22:30
Copy link
Contributor

@zekun000 zekun000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably better be a timer than counter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants