Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec] Fix the broken spec in aptos_framework, aptos_stdlib and move_stdlib #5970

Merged
merged 1 commit into from
Dec 23, 2022
Merged

[Spec] Fix the broken spec in aptos_framework, aptos_stdlib and move_stdlib #5970

merged 1 commit into from
Dec 23, 2022

Conversation

junkil-park
Copy link
Contributor

@junkil-park junkil-park commented Dec 21, 2022 •
edited
Loading

Description

  • This PR fixes the specs that have been broken due to the recent updates on the aptos framework.
  • This unblocks the specification work/collaboration.
  • Multiple TODOs are left for the unspecified functions.

Test Plan

@junkil-park
[Spec] Fix the broken spec in aptos_framework, aptos_stdlib and move_…
f386970 
…stdlib

- fixes the broken spec in aptos_move
- leaves TODOs for the unspecified functions
- unblock the specification collaboration
@junkil-park junkil-park enabled auto-merge (squash) December 23, 2022 08:46
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on f386970f49685a7448bcf3d4de9dc753bfa6dcbf

performance benchmark with full nodes : 6430 TPS, 6140 ms latency, 11500 ms p99 latency,(!) expired 540 out of 2746560 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> f386970f49685a7448bcf3d4de9dc753bfa6dcbf

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> f386970f49685a7448bcf3d4de9dc753bfa6dcbf (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7520 TPS, 5105 ms latency, 7100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: f386970f49685a7448bcf3d4de9dc753bfa6dcbf
compatibility::simple-validator-upgrade::single-validator-upgrade : 4560 TPS, 9060 ms latency, 12700 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: f386970f49685a7448bcf3d4de9dc753bfa6dcbf
compatibility::simple-validator-upgrade::half-validator-upgrade : 4777 TPS, 8296 ms latency, 10900 ms p99 latency,no expired txns
4. upgrading second batch to new version: f386970f49685a7448bcf3d4de9dc753bfa6dcbf
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6808 TPS, 5772 ms latency, 9000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> f386970f49685a7448bcf3d4de9dc753bfa6dcbf passed
Test Ok

@junkil-park junkil-park merged commit 768fe2e into main Dec 23, 2022
@junkil-park junkil-park deleted the jpark/fix-broken-spec branch December 23, 2022 09:33
@Markuze Markuze mentioned this pull request Dec 26, 2022
Closed
@Markuze Markuze mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahxephon89 rahxephon89 rahxephon89 approved these changes

@movekevin movekevin movekevin approved these changes

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

@meng-xu-cs meng-xu-cs Awaiting requested review from meng-xu-cs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junkil-park @rahxephon89 @movekevin