Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[smart_table] a lot of inline functions added #9752

Merged
merged 1 commit into from
Aug 28, 2023
Merged

[smart_table] a lot of inline functions added #9752

merged 1 commit into from
Aug 28, 2023

Conversation

lightmark
Copy link
Contributor

@lightmark lightmark commented Aug 24, 2023 •
edited
Loading

Description

see the implementations. all is missing here because it triggers the error mentioned in
#9717
#6615
again.
cc @wrwg @brmataptos

Test Plan

ut

@lightmark lightmark marked this pull request as ready for review August 24, 2023 06:06
@lightmark lightmark force-pushed the lightmark/smart_iteration branch 3 times, most recently from bff2266 to 2cb4ee8 Compare August 24, 2023 22:59
movekevin
movekevin approved these changes Aug 24, 2023
View reviewed changes
aptos-move/framework/aptos-stdlib/sources/data_structures/smart_vector.move
});
result
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about zip, zip_ref, etc. too :)

aptos-move/framework/aptos-stdlib/sources/data_structures/smart_vector.move
}

/// Filter the vector using the boolean function, removing all Ts for which `p(e)` is not true.
public inline fun filter<T: store + drop>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about find that accepts a lambda (instead of value)? vector needs one such function too :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vector already has that. I 'll add one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find doesn't work cuz it will trigger the bug #9717
#6615 again.

@lightmark lightmark force-pushed the lightmark/smart_iteration branch from 2cb4ee8 to 862fa91 Compare August 28, 2023 20:16
@lightmark lightmark enabled auto-merge (squash) August 28, 2023 20:34
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@lightmark lightmark force-pushed the lightmark/smart_iteration branch from 862fa91 to 575850f Compare August 28, 2023 21:43
@lightmark lightmark requested a review from junkil-park as a code owner August 28, 2023 21:43
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.6.2 ==> 575850f1404ad5d7c5632f6dabb5d21f51c0b432

Compatibility test results for aptos-node-v1.6.2 ==> 575850f1404ad5d7c5632f6dabb5d21f51c0b432 (PR)
1. Check liveness of validators at old version: aptos-node-v1.6.2
compatibility::simple-validator-upgrade::liveness-check : committed: 3225 txn/s, latency: 6685 ms, (p50: 6600 ms, p90: 10100 ms, p99: 10500 ms), latency samples: 183880
2. Upgrading first Validator to new version: 575850f1404ad5d7c5632f6dabb5d21f51c0b432
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1780 txn/s, latency: 16308 ms, (p50: 18700 ms, p90: 22300 ms, p99: 22500 ms), latency samples: 92560
3. Upgrading rest of first batch to new version: 575850f1404ad5d7c5632f6dabb5d21f51c0b432
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1849 txn/s, latency: 15589 ms, (p50: 18600 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 92460
4. upgrading second batch to new version: 575850f1404ad5d7c5632f6dabb5d21f51c0b432
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3258 txn/s, latency: 9445 ms, (p50: 9800 ms, p90: 13900 ms, p99: 14400 ms), latency samples: 136860
5. check swarm health
Compatibility test for aptos-node-v1.6.2 ==> 575850f1404ad5d7c5632f6dabb5d21f51c0b432 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 575850f1404ad5d7c5632f6dabb5d21f51c0b432

two traffics test: inner traffic : committed: 7091 txn/s, latency: 5528 ms, (p50: 5400 ms, p90: 6900 ms, p99: 10400 ms), latency samples: 3063720
two traffics test : committed: 100 txn/s, latency: 3453 ms, (p50: 3200 ms, p90: 4300 ms, p99: 8200 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.225, avg: 0.211", "QsPosToProposal: max: 0.149, avg: 0.132", "ConsensusProposalToOrdered: max: 0.542, avg: 0.516", "ConsensusOrderedToCommit: max: 0.495, avg: 0.464", "ConsensusProposalToCommit: max: 1.011, avg: 0.980"]
Max round gap was 1 [limit 4] at version 1602503. Max no progress secs was 4.026085 [limit 10] at version 1602503.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 575850f1404ad5d7c5632f6dabb5d21f51c0b432

Compatibility test results for aptos-node-v1.5.1 ==> 575850f1404ad5d7c5632f6dabb5d21f51c0b432 (PR)
Upgrade the nodes to version: 575850f1404ad5d7c5632f6dabb5d21f51c0b432
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4557 txn/s, latency: 7104 ms, (p50: 7500 ms, p90: 9900 ms, p99: 12000 ms), latency samples: 168640
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 575850f1404ad5d7c5632f6dabb5d21f51c0b432 passed
Test Ok

@lightmark lightmark merged commit 86cb824 into main Aug 28, 2023
@lightmark lightmark deleted the lightmark/smart_iteration branch August 28, 2023 22:19
0xmigo pushed a commit that referenced this pull request Aug 30, 2023
@lightmark
[smart_table] a lot of inline functions added (#9752)
26c1ec8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidiw davidiw davidiw approved these changes

@movekevin movekevin movekevin approved these changes

@saharct saharct Awaiting requested review from saharct

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

@junkil-park junkil-park Awaiting requested review from junkil-park

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lightmark @davidiw @movekevin