Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add indexation of ERC20 wrapper contracts #356

Merged
merged 14 commits into from
Apr 28, 2023
Merged

Feature: Add indexation of ERC20 wrapper contracts #356

merged 14 commits into from
Apr 28, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Apr 19, 2023 •
edited by jira bot
Loading

Description

Add indexation of the underlying contract in wrapped erc20 tokens

Task: OS-375

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@josemarinas josemarinas requested a review from Rekard0 April 20, 2023 15:26
@josemarinas josemarinas marked this pull request as ready for review April 20, 2023 15:26
@josemarinas josemarinas force-pushed the f/OS-375-index-the-underlaying-token branch from ee6ea65 to 7da9ee0 Compare April 24, 2023 09:50
brickpop
brickpop previously approved these changes Apr 25, 2023
View reviewed changes
@josemarinas josemarinas requested a review from Rekard0 April 25, 2023 10:50
@josemarinas josemarinas force-pushed the f/OS-375-index-the-underlaying-token branch from 6e3de8b to d4b8088 Compare April 25, 2023 12:16
Rekard0
Rekard0 previously approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Rekard0
Rekard0 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josemarinas josemarinas merged commit 47f1ee8 into develop Apr 28, 2023
@josemarinas josemarinas deleted the f/OS-375-index-the-underlaying-token branch April 28, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

@heueristik heueristik Awaiting requested review from heueristik

Assignees
No one assigned
Labels
subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemarinas @brickpop @Rekard0