Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: metadata mixup fix for develop #512

Merged
merged 9 commits into from
Dec 20, 2023
Merged

fix: metadata mixup fix for develop #512

merged 9 commits into from
Dec 20, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Dec 13, 2023 •
edited by jira bot
Loading

Description

See #507

Task ID: OS-901 (surfaced in spike OS-899)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

mathewmeconry and others added 8 commits August 28, 2023 10:25
@mathewmeconry
fix(subgraph): update to @graphprotocol/[email protected] (#453)
84a413f
@heueristik @mathewmeconry
fix: missing virtual keyword (#452)
c6f9c8e 
* fix: added missing virtual keywords.

* fix: correct misspelled filename

* docs: improved NatSpec

* chore: bump package versions

* Update packages/contracts/CHANGELOG.md

Co-authored-by: Mathias Scherer <[email protected]>

---------

Co-authored-by: Mathias Scherer <[email protected]>
@mathewmeconry
Deploy contracts and subgraph to sepolia (#475)
2a02e0b 
* feat: deploy v1.3.0-rc0 to sepolia

* feat: bump subgraph version to v1.3.0-rc0
feat: deploy sepolia subgraph

* fix(OS-638): fixes typo in implementation

* chore: fix formatting in helpers script
@heueristik
fix: ipfs returned an empty string (#485) (#495)
61d5352
@heueristik @mathewmeconry
chore: deploy 1.3.0-rc0 to arbitrum and arbitrumGoerli (#496)
40f342b 
* chore: prepared arbitrum deployment

* chore: deployed v1.3.0 to arbitrumGoerli

* docs: improved checklist

* chore: deployed v1.3.0 to arbitrum

* chore: deployed v1.3.0-rc0.4 npm packages

* chore: added manifests for arbitrum and arbitrumGoerli

* docs: improved deployment checklist

* docs: improved deployment checklist

* docs: fix typo

Co-authored-by: Mathias Scherer <[email protected]>

---------

Co-authored-by: Mathias Scherer <[email protected]>
@heueristik
fix: build and release metadata where swapped
ddfc7d5
@heueristik
fix: publish an empty JSON object to silence the EmptyReleaseMetadata…
94617aa 
… error
@heueristik
docs: improve checklists
7610592
@heueristik heueristik requested a review from Rekard0 December 13, 2023 17:41
Rekard0
Rekard0 previously approved these changes Dec 20, 2023
View reviewed changes
@github-actions github-actions bot removed the subgraph label Dec 20, 2023
@heueristik heueristik merged commit 1e6d56d into develop Dec 20, 2023
@heueristik heueristik deleted the hotfix/fix-metadata-mixup branch December 20, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewmeconry mathewmeconry mathewmeconry approved these changes

@josemarinas josemarinas josemarinas approved these changes

@Rekard0 Rekard0 Rekard0 left review comments

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heueristik @mathewmeconry @Rekard0 @josemarinas