Python unit test clean-up #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraabiakar
requested review from
halfflat and
thorstenhater
and removed request for
halfflat
halfflat
reviewed
Jun 24, 2021
| @@ -21,6 +21,7 @@ | |||
| import test_contexts_arbmpi | |||
| import test_contexts_mpi4py | |||
| import test_domain_decompositions | |||
| import simulator | |||
There was a problem hiding this comment.
I don't see anything that matches this module name; should this line be here?
There was a problem hiding this comment.
That's supposed to be test_simulator
There was a problem hiding this comment.
And it's for completeness. AFAICT, the try clause will always fail unless there's an options.py file in the same directory as test_* files and the runner.py file, which isn't the case at the moment.
halfflat
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_simulator.py: was originally removed in spike sorting on python side #1503 then accidentally merged again in Labels instead of indices for placeable item identfication. #1504.test_decor.pyand add it to the to the unit test runner.