Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run examples via scripts (closes #1566) #1631

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

schmitts
Copy link
Contributor

No description provided.

@schmitts schmitts force-pushed the run_examples_via_scripts branch from 7ed3853 to b3f2f8d Compare August 19, 2021 13:23
@schmitts schmitts force-pushed the run_examples_via_scripts branch from b3f2f8d to 1683104 Compare August 19, 2021 13:24
Copy link
Contributor

@brenthuisman brenthuisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, we needed this! Can you also update sanitize.yml?

@schmitts
Copy link
Contributor Author

We can add a follow up issue. I'm not 100% satisfied as we don't collect the examples. I tried but some examples need parameters so trivial globbing does not work.

@schmitts
Copy link
Contributor Author

Excellent, we needed this! Can you also update sanitize.yml?

Done.

@brenthuisman
Copy link
Contributor

You mean verify the results? Yes, that can be a separate PR.

@schmitts
Copy link
Contributor Author

You mean verify the results? Yes, that can be a separate PR.

I've meant to get the list of examples.

@brenthuisman brenthuisman merged commit 40aaa4a into arbor-sim:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants