Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class members in cable example #1641

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Fix class members in cable example #1641

merged 1 commit into from
Oct 8, 2021

Conversation

schmitts
Copy link
Contributor

@schmitts schmitts commented Sep 6, 2021 •
edited
Loading

Fixes that the parameters were mistakenly used from the surrounding args.

@thorstenhater
Copy link
Contributor

Hi,

in principle this looks good, but for the review: could you please a one-line description?

thorstenhater
thorstenhater requested changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add a short explanation on why and what happens here. It helps the reviewers to categorise your PR and start looking for context.

@schmitts
Copy link
Contributor Author

@thorstenhater ok now?

thorstenhater
thorstenhater approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thorstenhater thorstenhater merged commit 148e8d6 into arbor-sim:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorstenhater thorstenhater thorstenhater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmitts @thorstenhater