Feature/label dict #1711
Merged
Feature/label dict #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1535 by Helveg -- at least partially. |
|
Updates pybind11 to 2.8 as well. |
thorstenhater
requested changes
Oct 12, 2021
apeyser
force-pushed
the
feature/label_dict
branch
from
56080ca to
460adac
Compare
apeyser
force-pushed
the
feature/label_dict
branch
from
460adac to
898d090
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label_dict does not behave like a dict #1535
So I added a few members to the python label_dict and functionality to label_dict_proxy.