Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: add expected nmodl units #1756

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

noraabiakar
Copy link
Contributor

Fixes #1753

Copy link
Contributor

@schmitts schmitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor fixups, Arbor experts need to check the units

Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bcumming bcumming merged commit de8785f into arbor-sim:master Nov 12, 2021
@jlubo
Copy link
Collaborator

jlubo commented Nov 16, 2021

Thanks! This will help a lot reproducing results from other simulations.

bcumming pushed a commit to bcumming/arbor that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document expected units used for each nmodl quantity
4 participants