-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example and tutorial for two cells connected via a gap junction #1771
Example and tutorial for two cells connected via a gap junction #1771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
Thanks for the review @Helveg. I'd like to wait for green lights also from @noraabiakar and @thorstenhater. |
Ofcourse, that's why my checkmark is grey, I'm but a peon :') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new tutorial on gap junctions! I have some comments to better highlight the important parts of forming a gap junction connection since this is our first tutorial using them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed rereview! I just have one more comment.
assert gid in [0, 1] | ||
|
||
# create a bidirectional gap junction from cell 0 at label "gj_label" to cell 1 at label "gj_label" and back. | ||
return [arbor.gap_junction_connection((1 if gid == 0 else 0, 'gj_label'), 'gj_label', self.gj_g)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the weight here should be 1. gj_g
has a unit of uS but the weight of a connection is supposed to be unitless. The g
parameter of the gj
mechanism has a unit of uS can be set to gj_g
. Since this is a tutorial, it's better to avoid these sources of confusion.
…lls_connected_via_a_gap_junction
No description provided.