v0.6-rc #1814
Merged
v0.6-rc #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…example/single_cell_nml.py
noraabiakar
approved these changes
Jan 26, 2022
| @@ -92,11 +92,15 @@ jobs: | |||
| # See https://github.com/open-mpi/ompi/issues/6518 | |||
| OMPI_MCA_btl: "self,tcp" | |||
| steps: | |||
| - name: Get clang/gcc 8 | |||
| - name: Get clang/gcc 8, libxml2, Linux | |||
There was a problem hiding this comment.
Can we rename to "Linux: get clang/gcc 8, libxml2" (and "MacOS: get libxml2" below)
| with: | ||
| submodules: recursive | ||
| - name: Build and install Arbor using pip | ||
| run: python3 -m pip install --verbose --install-option="-DARB_VECTORIZE=ON" --install-option="-DARB_ARCH=native" . |
There was a problem hiding this comment.
Do we verify that vectorization is actually enabled?
max9901
pushed a commit
to max9901/arbor
that referenced
this pull request
Feb 3, 2022
* bump version to v0.6-rc
* Update `MANIFEST.in` and `scripts/run_python_examples.sh`
* Update Release instructions `docs/contrib/release.rst`
* Fix missing quotes in `python/example/single_cell_nml.py`
* Add testing to sdist creation in `ciwheel.yml`
* Rename `basic.yml` to `test-everything.yml`
* Remove Python examples step from matrix (mostly because plotting takes much CPU on macos)
* change to build /w nml
* add test of pip builds (`pip install` in addition to CMake builds)
* Python examples are tested here, once is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MANIFEST.inandscripts/run_python_examples.shdocs/contrib/release.rstpython/example/single_cell_nml.pyciwheel.ymlbasic.ymltotest-everything.ymlpip installin addition to CMake builds)