Bug fix: Fix voltage vector size in threshold_watcher contstructor #1820
+36
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryTimed out. |
|
bors try |
tryBuild succeeded: |
thorstenhater
requested changes
Feb 2, 2022
| { | ||
| arb_assert(n_cv_==thresholds.size()); | ||
| reset(); | ||
| // reset() needs to be called before this is ready for use |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following 2 issues:
threshold_watcher::v_prev_is being constructed from a pointer toshared_state::voltageand a size argument not equal to the size of that vector. This isn't usually a problem because the size used is typically less than the maximum size of thevoltagevector. However, it can cause problems if that assumption fails.v_prev_is copied over fromshared_state::voltagebefore that vector is initialized toinit_voltageinshared_state::reset. This can cause incorrect results at the very first application ofthreshold_watcher::test.