Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modcc: Allow redundant, but correct READ declaration. #1936

Merged
merged 2 commits into from
Aug 4, 2022
Merged

modcc: Allow redundant, but correct READ declaration. #1936

merged 2 commits into from
Aug 4, 2022

Conversation

thorstenhater
Copy link
Contributor

Fixes #1845

boeschf
boeschf approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@brenthuisman brenthuisman merged commit 4501d39 into arbor-sim:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boeschf boeschf boeschf approved these changes

@AdhocMan AdhocMan Awaiting requested review from AdhocMan

@brenthuisman brenthuisman Awaiting requested review from brenthuisman

Assignees
No one assigned
Labels
bug modcc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declaring both reading and writing an ion leads to modcc error
3 participants
@thorstenhater @boeschf @brenthuisman