Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦑 Excise time #1967

Merged

Conversation

thorstenhater
Copy link
Contributor

Excises time from NMODL as per our policies not to let users peek behind the curtain.

Closes #1252

@thorstenhater
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 5, 2022
@bors
Copy link

bors bot commented Sep 5, 2022

try

Build failed:

@thorstenhater
Copy link
Contributor Author

@bcumming the runner is having another bad hair day.

@boeschf
Copy link
Contributor

boeschf commented Sep 5, 2022

This will potentially break some code where users rely on this feature. What's the our policy with respect to deprecation warnings/breaking changes?

@thorstenhater
Copy link
Contributor Author

That we are in 0.x.y land and will politely inform our users ;) Time has been in NMODL mainly for implementing I_Clamps, which we do differently now. None of our internal catalogues uses it.

In general we try to minimise our ABI surface and try to keep our users away from the soft underbelly of Arbor.
Using time someone could try to implement their own solvers/integrator, which we decidedly do not like.
If desparately needed, adding a trivial ODE (t' = 1) restores it, but makes our dislike obvious.
This also saves an array in shared state, (plus one on the GPU, if present).

@thorstenhater thorstenhater merged commit 0644cf8 into arbor-sim:master Sep 5, 2022
@thorstenhater thorstenhater deleted the qa/remove-time-from-mechs branch September 5, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: remove time parameter from mechanisms.
2 participants