Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: gpu mechanism init #2095

Merged
merged 1 commit into from
Mar 10, 2023
Merged

BUGFIX: gpu mechanism init #2095

merged 1 commit into from
Mar 10, 2023

Conversation

boeschf
Copy link
Contributor

@boeschf boeschf commented Mar 7, 2023

Fix GPU code generation when initializing mechanism without arrays by not launching multiply kernel. Would otherwise lead to runtime error.

@boeschf boeschf requested a review from thorstenhater March 7, 2023 13:46
thorstenhater
thorstenhater approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stupid oversight! 👍 Thanks for fixing.

Out of curiosity, how did you find this and how did it slip under the radar for so long?

@boeschf
Copy link
Contributor Author

boeschf commented Mar 10, 2023

I ran the unit tests on Piz daint. Unfortunately, we don't run anything on GPU in the github tests, and bors is borked still.

@boeschf boeschf merged commit 8671a19 into arbor-sim:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorstenhater thorstenhater thorstenhater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boeschf @thorstenhater