Polish event dispatch #2434
Merged
Polish event dispatch #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e' into perf/better-sorting-in-event-queue
ErbB4
previously approved these changes
Jan 7, 2025
Reason: STL distributions are platform dependent, thus cause different results on AClang ./. GCC+Clang
jlubo
reviewed
Mar 5, 2025
arbor/backends/event_stream_base.hpp
Outdated
| } | ||
|
|
||
| // TODO parallelise over streams, however, need a proper testcase/benchmark. |
There was a problem hiding this comment.
We should have an issue for that.
There was a problem hiding this comment.
I can make one, it's a very open ended project, though
example/brunel/brunel.cpp
Outdated
| while(m) { | ||
| cell_gid_type val = dis(gen); | ||
| // simple, compiler independent int in range |
There was a problem hiding this comment.
Since this is just an example model, I guess it's fine. But there might be a bias introduced by this approach (see here). So adding a warning note as a comment would be good.
There was a problem hiding this comment.
Good point, fixed.
jlubo
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-factor event dispatch, making it slightly faster.
Builds on #2433
Closes #2431