Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding to alignments grouping #28

Closed
wants to merge 3 commits into from
Closed

adding to alignments grouping #28

wants to merge 3 commits into from

Conversation

justinbansal
Copy link
Contributor

@justinbansal justinbansal commented Feb 13, 2024

This change expands the options inside of the labels.alignments grouping. It should be noted that we still have a left_to_right and right_to_left key available outside of the alignments group but still under labels. Assuming we only have to change the one file and the rest will update accordingly.

Should these be removed?

https://github.com/archetype-themes/locales/blob/main/locales/en.default.schema.json#L418

@justinbansal justinbansal requested a review from t-kelly February 13, 2024 15:47
@justinbansal justinbansal self-assigned this Feb 13, 2024
Copy link
Member

@t-kelly t-kelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinbansal justinbansal requested a review from t-kelly March 12, 2024 19:50
@t-kelly
Copy link
Member

t-kelly commented Mar 13, 2024

Looks like something happened to indentation?

@justinbansal
Copy link
Contributor Author

Redid in #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants