-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Columns field inside block component don't have block ids #2177
Comments
haringsrob
added a commit
that referenced
this issue
Mar 17, 2023
haringsrob
added a commit
that referenced
this issue
Mar 17, 2023
haringsrob
added a commit
that referenced
this issue
Mar 17, 2023
zeezo887
pushed a commit
to zeezo887/twill
that referenced
this issue
Apr 10, 2023
zeezo887
pushed a commit
to zeezo887/twill
that referenced
this issue
Apr 10, 2023
This reverts commit 4a69897.
zeezo887
pushed a commit
to zeezo887/twill
that referenced
this issue
Apr 10, 2023
zeezo887
pushed a commit
to zeezo887/twill
that referenced
this issue
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Columns field inside block component don't have block ids.
Field id "title-1678470408916" should be "blocks[5][title]-1678470408916".
Steps to reproduce
return Form::make([ Columns::make() ->left([ Input::make()->name('title') ]) ->right([ Wysiwyg::make()->name('text') ]), Input::make()->name('test') ]);
Expected result
Input id should be "blocks[INXED][NAME]-ID"
Actual result
Input id is "NAME-ID"
Versions
Twill: 3-RC4 / git
Laravel: 9.52.4
PHP: 8.0
Database: sqlite
The text was updated successfully, but these errors were encountered: