Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns field inside block component don't have block ids #2177

Closed
EpicKau opened this issue Mar 10, 2023 · 0 comments · Fixed by #2192
Closed

Columns field inside block component don't have block ids #2177

EpicKau opened this issue Mar 10, 2023 · 0 comments · Fixed by #2192

Comments

@EpicKau
Copy link

EpicKau commented Mar 10, 2023

Description

Columns field inside block component don't have block ids.
Field id "title-1678470408916" should be "blocks[5][title]-1678470408916".

Steps to reproduce

return Form::make([ Columns::make() ->left([ Input::make()->name('title') ]) ->right([ Wysiwyg::make()->name('text') ]), Input::make()->name('test') ]);

Expected result

Input id should be "blocks[INXED][NAME]-ID"

Actual result

Input id is "NAME-ID"

image2
image

Versions

Twill: 3-RC4 / git
Laravel: 9.52.4
PHP: 8.0
Database: sqlite

haringsrob added a commit that referenced this issue Mar 17, 2023
haringsrob added a commit that referenced this issue Mar 17, 2023
zeezo887 pushed a commit to zeezo887/twill that referenced this issue Apr 10, 2023
zeezo887 pushed a commit to zeezo887/twill that referenced this issue Apr 10, 2023
zeezo887 pushed a commit to zeezo887/twill that referenced this issue Apr 10, 2023
zeezo887 pushed a commit to zeezo887/twill that referenced this issue Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant