Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add setters to the controller. #1716

Merged
merged 10 commits into from
Jul 4, 2022
Merged

[3.x] Add setters to the controller. #1716

merged 10 commits into from
Jul 4, 2022

Conversation

haringsrob
Copy link
Contributor

Adds many options to set in the controller like:

    public function setUpController(): void
    {
        $this->enableShowImage();
    }

instead of modifying:

$indexOptions []

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1716 (65471d5) into 3.x (29da08e) will increase coverage by 0.17%.
The diff coverage is 78.09%.

@@             Coverage Diff              @@
##                3.x    #1716      +/-   ##
============================================
+ Coverage     60.10%   60.27%   +0.17%     
- Complexity     3226     3280      +54     
============================================
  Files           257      258       +1     
  Lines          9777     9893     +116     
============================================
+ Hits           5876     5963      +87     
- Misses         3901     3930      +29     
Impacted Files Coverage Δ
src/Models/Model.php 65.07% <ø> (ø)
src/Services/Listings/Columns/NestedData.php 58.33% <0.00%> (-41.67%) ⬇️
src/Services/Listings/Columns/Relation.php 75.00% <0.00%> (-25.00%) ⬇️
src/Models/Behaviors/HasMedias.php 44.52% <58.33%> (-0.26%) ⬇️
src/Http/Controllers/Admin/ModuleController.php 76.72% <73.87%> (-0.05%) ⬇️
src/Services/Listings/TableColumn.php 98.70% <94.11%> (-1.30%) ⬇️
src/TwillRoutes.php 87.35% <95.55%> (+7.81%) ⬆️
.../Http/Controllers/Admin/NestedModuleController.php 100.00% <100.00%> (ø)
src/Repositories/ModuleRepository.php 61.23% <100.00%> (+0.36%) ⬆️
src/RouteServiceProvider.php 70.27% <100.00%> (-7.01%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29da08e...65471d5. Read the comment docs.

@haringsrob haringsrob merged commit 629d23e into 3.x Jul 4, 2022
@haringsrob haringsrob deleted the add-controller-setters branch July 4, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant