[3.x] Fix return type

[aksiome]

A quick fix to silence IDE errors

I've noticed that setter methods used the self return type when returning $this. I believe it's best to return static now. This way users can extend classes without getting errors when chaining method calls.

I also removed the slugs mixin from the model interface since it is supposed to be an optional trait. Noticed it was added with the caching route fix but I'm not entirely sure why.

[what-the-diff]

• Removed HasSlug trait from TwillModelContract
• Changed return type of newInstance() method in Block class to static instead of self
• Changed return types for default(), label(), note(), required() and disabled methods in BaseFormField class to static instead of self
• Added missing use statement for A17\Twill\Models\Behaviors namespace at the top of BlockEditor, Browser, Checkbox, DatePicker and Files classes
• Replaced all occurrences (except one) with "static" keyword as a replacement for "self" keyword when defining return types on public functions inside these files:
• Changed the return type of all methods to static
• Removed unused imports in Repeater and MultiSelect fields
• Changed the return type of some methods from self to static
• Added a missing use statement in Form class
• Changed the return type of all methods in QuickFilter and TwillBaseFilter to static
• Added a default sort direction for TableColumns (ASC)

[codecov]

Codecov Report

Base: 59.92% // Head: 59.92% // No change to project coverage 👍

Coverage data is based on head (4ea3e4a) compared to base (aa6d0f2).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff            @@
##                3.x    #2140   +/-   ##
=========================================
  Coverage     59.92%   59.92%           
  Complexity     3898     3898           
=========================================
  Files           303      303           
  Lines         15014    15014           
=========================================
  Hits           8997     8997           
  Misses         6017     6017           

Impacted Files	Coverage Δ
src/Services/Forms/Fields/Checkbox.php	27.77% <0.00%> (ø)
src/Services/Forms/Fields/Input.php	29.41% <0.00%> (ø)
src/Services/Forms/Fields/Map.php	29.41% <0.00%> (ø)
src/Services/Forms/Fields/Medias.php	20.58% <0.00%> (ø)
src/Services/Forms/Fields/MultiSelect.php	25.00% <0.00%> (ø)
...ervices/Forms/Fields/Traits/CanHaveButtonOnTop.php	0.00% <0.00%> (ø)
src/Services/Forms/Fields/Traits/CanReorder.php	0.00% <0.00%> (ø)
src/Services/Forms/Fields/Traits/HasBorder.php	0.00% <0.00%> (ø)
src/Services/Forms/Fields/Traits/HasFieldNote.php	0.00% <0.00%> (ø)
src/Services/Forms/Fields/Traits/HasMax.php	0.00% <0.00%> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ifox]

Awesome @aksiome, we were actually discussing addressing this with @haringsrob a couple days ago. And @joyceverheije was looking into it to to fix PHPstan issues.

Thank you for working on this!

[CLAassistant]

All committers have signed the CLA.

[haringsrob]

Hey @aksiome this was indeed on my list too long! Thanks for fixing, the capsule phpcs issue is fixed in another pr so this is good to go!