Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 10 support. #2170

Merged
merged 11 commits into from
Mar 10, 2023
Merged

Laravel 10 support. #2170

merged 11 commits into from
Mar 10, 2023

Conversation

haringsrob
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Mar 3, 2023

  • Update composer.json
  • Add timezone to github actions
  • Fix datepicker component (allowInput) and pubAccordion component (startDate, endDate)
  • Cast deleted_at as datetime in Group model, Role model and User model
  • Remove dates from models: Group, Role & User

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.04 ⚠️

Comparison is base (41a64da) 59.93% compared to head (f638bbd) 59.90%.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.x    #2170      +/-   ##
============================================
- Coverage     59.93%   59.90%   -0.04%     
  Complexity     3904     3904              
============================================
  Files           303      303              
  Lines         15039    15039              
============================================
- Hits           9014     9009       -5     
- Misses         6025     6030       +5     
Impacted Files Coverage Δ
src/Models/Group.php 50.00% <ø> (ø)
src/Models/Role.php 68.18% <ø> (ø)
src/Models/User.php 82.30% <ø> (ø)
src/Repositories/Behaviors/HandleDates.php 50.00% <40.00%> (-41.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -77,7 +77,7 @@ public function testCanResetPassword()
'token' => Notification::token(),
]);

$this->assertSee('Your password has been reset!');
$this->assertSee('You don&#039;t have any activity yet.');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ifox not sure but this started to fail so I changed the assert to a different piece of text on the page.

@haringsrob haringsrob merged commit 2ccd4a7 into 3.x Mar 10, 2023
@haringsrob haringsrob deleted the laravel-10 branch March 10, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant