Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling groups of fields fix #2277

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Handling groups of fields fix #2277

merged 1 commit into from
Aug 10, 2023

Conversation

yamaha252
Copy link
Contributor

If I use a dot as fieldsGroupsFormFieldNameSeparator some values in a group is not saves because laravel's method Arr::forget has a deep removing functionality which is not necessary here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Use native fields cleaning to avoid a deep values removing
@CLAassistant
Copy link

CLAassistant commented May 30, 2023

CLA assistant check
All committers have signed the CLA.

@ifox
Copy link
Member

ifox commented May 30, 2023

Thanks @yamaha252 that makes sense. Can you please sign the CLA?

@ifox ifox merged commit 7be10cc into area17:3.x Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants