fix: model not implementing has media should only throw exception if no custom callback is provided #2494
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's very much possible to implement an Image column with a custom thumbnail (eg coming from youtube or any other service)
Right now the following throws an exception if the
Video
model doesn't useHasMedias
But it shouldn't because of the custom render method provided
BTW I noticed a related issue on the browser, using any other field name than
thumbnail
on image in the browser columns results in the image being displayed as text instead of as an image as well as the order of the columns being wrong