Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized behavior to publish shutter data with sensor request #22353

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

stefanbode
Copy link
Contributor

@stefanbode stefanbode commented Oct 24, 2024

Description:

Before the shutterposition and other data where published every second as sensor data. Building rules on this data was difficult. With the change the data to shutter data is now only published every second, if the shutter is moving

Related issue (if applicable): fixes #
#22282

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241023
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit fd37801 into arendst:development Oct 24, 2024
59 checks passed
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 7, 2024
…st#22353)

* avoid shutter sensor data published ever

* avoid shutter data report on sensor trigger
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 10, 2024
…st#22353)

* avoid shutter sensor data published ever

* avoid shutter data report on sensor trigger
@jziolkowski
Copy link
Contributor

@stefanbode can you please elaborate more about the reasoning behind that? I did not observe the data being published every 1s, and only each teleperiod (StatusSNS) and while movement (RESULT)

@stefanbode
Copy link
Contributor Author

This is only on the sensor bus that is used for rules and to update the webpage. You do not see this normally. That's the reason i was also not aware. But when you create a rule an just print the value you will see the rules gets triggered every second. This was the same with e.g. shutterposition

@jziolkowski
Copy link
Contributor

Ok, so is there some middle ground? So that the shutter positions can be still obtained with status?

Maybe a solution would be to update the existing StatusSHT so that it returns everything available about shutters? not only their config, but the current position etc?

OR find a way to have that data available with telemetry, as it was before?

@stefanbode
Copy link
Contributor Author

There should be no change in the telemetry reporting. If so this is a bug and needs a fix

@jziolkowski
Copy link
Contributor

yep, it's gone from StatusSNS

@jziolkowski
Copy link
Contributor

as of 13.0.x it works, on latest builds not anymore. I can't tell which revision exactly made the regression, but here we are :)

@stefanbode
Copy link
Contributor Author

Accepted as regression. Will fix

@jziolkowski
Copy link
Contributor

Any plans on fixing that?

@stefanbode
Copy link
Contributor Author

Oh yes. Just missed it. Work on it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants