-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized behavior to publish shutter data with sensor request #22353
Conversation
…st#22353) * avoid shutter sensor data published ever * avoid shutter data report on sensor trigger
…st#22353) * avoid shutter sensor data published ever * avoid shutter data report on sensor trigger
@stefanbode can you please elaborate more about the reasoning behind that? I did not observe the data being published every 1s, and only each teleperiod (StatusSNS) and while movement (RESULT) |
This is only on the sensor bus that is used for rules and to update the webpage. You do not see this normally. That's the reason i was also not aware. But when you create a rule an just print the value you will see the rules gets triggered every second. This was the same with e.g. shutterposition |
Ok, so is there some middle ground? So that the shutter positions can be still obtained with status? Maybe a solution would be to update the existing StatusSHT so that it returns everything available about shutters? not only their config, but the current position etc? OR find a way to have that data available with telemetry, as it was before? |
There should be no change in the telemetry reporting. If so this is a bug and needs a fix |
yep, it's gone from StatusSNS |
as of 13.0.x it works, on latest builds not anymore. I can't tell which revision exactly made the regression, but here we are :) |
Accepted as regression. Will fix |
Any plans on fixing that? |
Oh yes. Just missed it. Work on it today |
Description:
Before the shutterposition and other data where published every second as sensor data. Building rules on this data was difficult. With the change the data to shutter data is now only published every second, if the shutter is moving
Related issue (if applicable): fixes #
#22282
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass