Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Tasmota compile with USE_BERRY but without USE_WEBCLIENT #23123

Closed
wants to merge 1 commit into from

Conversation

GMagician
Copy link
Contributor

Despite comments say you can disable USE_WEBCLIENT when you habe USE_BERRY, if you do that you get a compile error because 'StreamBeBytesWriter' is not defined.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.3.250302
  • I accept the CLA.

Despite comments say you can disable USE_WEBCLIENT when you habe USE_BERRY, if you do that you get a compile error.
@s-hadinger
Copy link
Collaborator

Sorry but this looks half baked. If your intent is to avoid any outgoing request, then becloader needs to be disabled as well.
I'm not even sure USE_WEB_CLIENT makes sense anymore, or it should be reconsidered more globally. I don't see the value so unless you're willing to do this global change, USE_WEB_CLIENT option will be removed (I.e. Always included)

@GMagician GMagician closed this Mar 8, 2025
@GMagician GMagician deleted the Fix-compile-error branch March 8, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants